Test package:

ethernet-pack.zip

Thank you @Jookia!

As salty as I was in my PR, I'm glad to see kcgen is doing the work I wouldn't to get this merged. Slirp for everyone!

@kcgen Your timing is impeccable, was just reading through the comments of the old PR.. 😱

Oh that reminds me, will this be enabled on Windows? DOSBox-X disables the Win32 code (which I tested and made work) because glib and slirp don't support Windows XP.

Our target is to support Windows 7 or newer so on that basis it should be enabled.

https://wiki.gnome.org/Projects/GLib/SupportedPlatforms

Windows: minimum version is Windows 8, minimum build chain is Visual Studio 2012.

I think its unlikely we are going to drag everyone else down to support Windows 7.

https://gs.statcounter.com/windows-version-market-share/desktop/worldwide/

Windows 8+ has a 86.5% market share.

Oh that reminds me, will this be enabled on Windows? DOSBox-X disables the Win32 code (which I tested and made work) because glib and slirp don't support Windows XP.

vcpkg (as of right now) currently doesn't packagelibslirp, so it's not currently an option for the visual studio build. But (good news!) One of the sticking points has been glib, and we know it's now (or soon to be) in much better shape on Windows, so this should unlock more depenent packages (like libslirp).

Since your PR, @shermp has contributed a newly authored and improved msys2 CI stack, producing all-features-enabled binaries: and libslirp is available under msys2. So no matter what, we will have libslirp in these builds going forward.

had a small issue when compiling dosbox-x requesting libslirp awhile ago, it might have been resolved by debian11/raspbian11

previous debian10 doesnt have any libslirp in the repo

raspbian 11/debian11:

librust-libslirp-dev/stable,stable 4.3.0-3 armhf
librust-libslirp-sys-dev/stable,stable 4.2.0-1 armhf
libslirp-dev/stable,stable 4.4.0-1+deb11u2 armhf
libslirp-helper/stable 4.3.0-3 armhf
libslirp0/stable 4.4.0-1+deb11u2 armhf
libvdeplug-slirp/stable 0.1.0-2 armhf
libvdeslirp-dev/stable,stable 0.1.1-1 armhf
libvdeslirp0/stable 0.1.1-1 armhf
slirp4netns/stable 1.0.1-2 armhf
slirp/stable 1:1.0.17-11 armhf

vs ubuntu x86_64

slirp/bionic-updates,bionic-security 1:1.0.17-8ubuntu18.04.1 amd64
slirp/bionic 1:1.0.17-8build1 amd64

resolution was to disable networking at build time or compile slirp and install it separately

libslirp (optional)
For slirp backend of NE2000 networking support.
Get it from https://gitlab.freedesktop.org/slirp/libslirp

depends if staging is building this static linked or dynamically with the src
just a small note for compatibility

had a small issue when compiling dosbox-x requesting libslirp awhile ago, it might have been resolved by debian11/raspbian11 ...

Perhaps @kcgen should add the slirp wrap as a fallback if required. It exists in the meson wrapdb.

Oh cool, port forwarding. I think DOSBox-X took that. Awesome!

Just to confirm: The libslirp.h thing might have been a bug. I'm not sure, I don't remember entirely but I do recall a bug with libslirp directories not working with Homebrew on macOS.

Oh cool, port forwarding. I think DOSBox-X took that. Awesome!

Thanks @Jookia ; yup - @Wengier 's pulled that commit into X already. Soon enough when we get this merged, the two projects will be able to communicate via TCP with one acting as the server. Fun times indeed, all thanks to your contribution!

Just to confirm: The libslirp.h thing might have been a bug. I'm not sure, I don't remember entirely but I do recall a bug with libslirp directories not working with Homebrew on macOS.

Thanks for the heads up. Still chipping away at the CI side as time permits, so this is good to know.

Woot!

Unfortunately in my tests on macOS it seems as if no actual network traffic is forwarded outside of Dosbox.

I loaded the ne2000 driver successfully, dhcp assigned the expected IP addresses (IP 10.0.2.15, gateway 10.0.2.2, nameserver 10.0.2.3) and the nameserver IP can be pinged, but when I try to ping e.g. google.com all I get is timeouts.

I also tried dnstest from the mTCP package but only get the following:

Dns: Sending query to 10.0.2.3 for google.com
Dns: Timeout finding: google.com
Dns: No activity, pushing again
Dns: Resending initial query

which then repeats without success. Annoyingly there are also no log messages in the console related to SLIRP that could help with debugging.

Please open a bug for that issue and provide logs, etc.

Note that ICMP (ping) does not work on all platforms with SLIRP (I know it doesn't work on Windows), so I wouldn't rely on ping as an indication on whether it works or not.

I'll prepare a more comprehensive issue for it if I get around to it. I went back to testing ping because I couldn't get anything else to work either.

@PatTheMav Please open a new ticket on our issue tracker over this instead of using this page for issues.

Thank you for telling me twice, especially after I already mentioned that I'll prepare a more comprehensive issue on that.

Just trying to keep pages related to code reviews clean from issues. Thats all.