KEMBAR78
Continue Enet PR by kcgen · Pull Request #1441 · dosbox-staging/dosbox-staging · GitHub
Skip to content

Continue Enet PR #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Dec 18, 2021
Merged

Continue Enet PR #1441

merged 36 commits into from
Dec 18, 2021

Conversation

@kcgen
Copy link
Member

@kcgen kcgen commented Dec 17, 2021 •
edited
Loading

Thanks to:

Note: Enet introduce compiler warnings and PVS Studio issues, which have been permitted in this PR. They've been submitted upstream and are being tracked here.

Fixes #947.

@kcgen kcgen force-pushed the kc/sduensin-enet-pr-1 branch 3 times, most recently from cca6609 to f89e59a Compare December 17, 2021 04:37
GranMinigun
GranMinigun reviewed Dec 17, 2021
View reviewed changes
@kcgen kcgen added the enhancement New feature or enhancement of existing features label Dec 17, 2021
@kcgen kcgen force-pushed the kc/sduensin-enet-pr-1 branch 4 times, most recently from 978b4e0 to 4a8622b Compare December 17, 2021 16:54
@dosbox-staging dosbox-staging deleted a comment from lgtm-com bot Dec 17, 2021
@dosbox-staging dosbox-staging deleted a comment from lgtm-com bot Dec 17, 2021
@dosbox-staging dosbox-staging deleted a comment from lgtm-com bot Dec 17, 2021
@kcgen kcgen force-pushed the kc/sduensin-enet-pr-1 branch from 4a8622b to be904df Compare December 17, 2021 20:16
Scott Duensing and others added 14 commits December 17, 2021 15:03
kcgen added 20 commits December 17, 2021 15:03
@kcgen
Set the initialized state after deinitializing ENet
ea81a29
@kcgen
Set the client to the nullptr after destroying it
a4a73ba
@kcgen
Sanity check the isopen state on failed host creation
be908fb
@kcgen
Sanity check the isopen state when destroying the host
128a618
@kcgen
Set the host to the nullptr after destroying it
f285f26
@kcgen
Assert the host pointer is valid before using it
ed5aab7
@kcgen
Add return-code checks to ENETClientSocket's Putchar
35686ff
@kcgen
Avoid a double-negative when checking buffer size
c5fc203
@kcgen
Add return-code checks to ENETClientSocket's SendArray
73dc5e1
@kcgen
Assert and reinterpret_cast buffer in GetRemoteAddressString
8dd66b7
@kcgen
Check the Enet connection and client before using it
b0789d8
@kcgen
Sanity check the Enet packet before using it
0894d8e
@kcgen
Make Enet client open message similar to close message
8a4147a
@kcgen
Add SERIAL.COM to the VisualStudio solution
8476e0b
@kcgen
Adjust wording and line-count of SERIAL help screen
469e318 
 - Separate usage into two modes: list or configure.
 - Re-order types by priority (i.e., the majority of users who
   use this command are interested in MODEM or NULLMODEM).
 - Add descriptions to examples.
 - Reduce line-count to fit in 25-row screens.
@kcgen
Check ENet's multi-byte packet size before send
1e3b27b
@kcgen
Strongly type the user type as SERIAL_PORT_TYPE
618598f
@kcgen
Log ENet connection details include IP and port
926363b
@kcgen
Permit additional Windows warnings for ENet lib
1b7b99a
@kcgen
Destroy existing ENet connections if needed
b75094a
@kcgen kcgen force-pushed the kc/sduensin-enet-pr-1 branch from be904df to b75094a Compare December 18, 2021 00:59
@lgtm-com
Copy link

lgtm-com bot commented Dec 18, 2021

This pull request introduces 2 alerts when merging b75094a into 7ce4293 - view on LGTM.com

new alerts:

  • 2 for Comparison result is always the same

@kcgen kcgen mentioned this pull request Dec 18, 2021
Closed
@dosbox-staging dosbox-staging deleted a comment from lgtm-com bot Dec 18, 2021
@dosbox-staging dosbox-staging deleted a comment from lgtm-com bot Dec 18, 2021
@kcgen
Copy link
Member Author

kcgen commented Dec 18, 2021

Note: the two LGTM alerts are coming from enet.h.

@kcgen kcgen merged commit cf08b68 into main Dec 18, 2021
@kcgen kcgen deleted the kc/sduensin-enet-pr-1 branch December 18, 2021 08:38
@kcgen kcgen added this to the 0.78 release milestone Dec 21, 2021
@Grounded0 Grounded0 added the networking Issues related to networking label Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@GranMinigun GranMinigun GranMinigun left review comments

@Grounded0 Grounded0 Grounded0 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sduensin sduensin

@kcgen kcgen

@GranMinigun GranMinigun

Labels

enhancement New feature or enhancement of existing features networking Issues related to networking

Projects

None yet

Milestone

0.78

Development

Successfully merging this pull request may close these issues.

IPX tunnel enhancement

4 participants

@kcgen @GranMinigun @Grounded0 @sduensin