KEMBAR78
Add detection for quote characters in values by sourabhmarathe · Pull Request #174 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Add detection for quote characters in values #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 7, 2020
Merged

Add detection for quote characters in values #174

merged 9 commits into from
May 7, 2020

Conversation

sourabhmarathe
Copy link
Contributor

@sourabhmarathe sourabhmarathe commented May 3, 2020 •
edited by mgrachev
Loading

Added a new checker for quote characters. Includes tests for values with single and double quotes, and correct case.

✔ Checklist:

  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated (for bug fixes / features).

@codecov-io
Copy link

codecov-io commented May 3, 2020 •
edited
Loading

Codecov Report

Merging #174 into master will decrease coverage by 0.07%.
The diff coverage is 97.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   97.86%   97.78%   -0.08%     
==========================================
  Files          11       12       +1     
  Lines         844      950     +106     
==========================================
+ Hits          826      929     +103     
- Misses         18       21       +3
Impacted Files Coverage Δ
src/checks/quote_character.rs 95.23% <95.23%> (ø)
src/checks.rs 100.00% <100.00%> (ø)
src/common.rs 97.07% <100.00%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 354095c...db22c29. Read the comment docs.

@sourabhmarathe sourabhmarathe mentioned this pull request May 3, 2020
Closed
@mgrachev
Copy link
Member

mgrachev commented May 4, 2020

@sourabhmarathe 👋Thank you for your contribution! 🚀

I need a bit more time to review your PR.

@mgrachev mgrachev linked an issue May 4, 2020 that may be closed by this pull request
Add check: QuoteCharacter #171
Closed
mgrachev
mgrachev requested changes May 6, 2020
View reviewed changes
Copy link
Member

@mgrachev mgrachev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some comments. Could you please fix them?

@sourabhmarathe
Copy link
Contributor Author

Yes, I will make these changes.

@mgrachev
Copy link
Member

mgrachev commented May 7, 2020

@sourabhmarathe Thank you!

Please, also add the information about your PR in the CHANGELOG.

@sourabhmarathe
Copy link
Contributor Author

@sourabhmarathe Thank you!

Please, also add the information about your PR in the CHANGELOG.

I added this PR to CHANGELOG.md. It should be all set!

@mgrachev mgrachev merged commit 1820e4d into dotenv-linter:master May 7, 2020
@mgrachev
Copy link
Member

mgrachev commented May 7, 2020 •
edited
Loading

@sourabhmarathe Excellent work! Thank you ❤️

If it’s not difficult for you, please support the project - click on the star in this repository ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add check: QuoteCharacter

3 participants

@sourabhmarathe @codecov-io @mgrachev