KEMBAR78
Add ability to skip checks by mgrachev · Pull Request #178 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Add ability to skip checks #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2020
Merged

Add ability to skip checks #178

merged 2 commits into from
May 23, 2020

Conversation

@mgrachev
Copy link
Member

@mgrachev mgrachev commented May 11, 2020 •
edited
Loading

✔ Checklist:

  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated (for bug fixes / features).

Resolve: #168

@mgrachev mgrachev force-pushed the skip-checks branch 3 times, most recently from f49c3ca to effa363 Compare May 11, 2020 09:58
@mgrachev mgrachev added the feature New feature or request label May 11, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020 •
edited
Loading

Codecov Report

Merging #178 into master will decrease coverage by 0.17%.
The diff coverage is 96.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
- Coverage   96.71%   96.53%   -0.18%     
==========================================
  Files          14       14              
  Lines        1096     1156      +60     
==========================================
+ Hits         1060     1116      +56     
- Misses         36       40       +4
Impacted Files Coverage Δ
src/checks/ending_blank_line.rs 84.21% <0.00%> (-7.22%) ⬇️
src/lib.rs 93.90% <96.87%> (-0.91%) ⬇️
src/checks.rs 100.00% <100.00%> (ø)
src/checks/duplicated_key.rs 100.00% <100.00%> (ø)
src/checks/extra_blank_line.rs 91.66% <100.00%> (+0.55%) ⬆️
src/checks/incorrect_delimiter.rs 96.47% <100.00%> (+0.12%) ⬆️
src/checks/key_without_value.rs 93.33% <100.00%> (+0.47%) ⬆️
src/checks/leading_character.rs 96.59% <100.00%> (+0.12%) ⬆️
src/checks/lowercase_key.rs 92.85% <100.00%> (+0.54%) ⬆️
src/checks/quote_character.rs 95.45% <100.00%> (+0.21%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cfc8e0...4f17d74. Read the comment docs.

@mgrachev mgrachev force-pushed the skip-checks branch 3 times, most recently from c62faaf to 4babd46 Compare May 21, 2020 18:47
@mgrachev
Add ability to skip checks
bcb3d7a 
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@mgrachev mgrachev requested a review from mstruebing May 21, 2020 18:50
@mgrachev mgrachev marked this pull request as ready for review May 21, 2020 18:50
@mgrachev mgrachev changed the title WIP: Add ability to skip checks Add ability to skip checks May 21, 2020
mstruebing
mstruebing requested changes May 23, 2020
View reviewed changes
Copy link
Member

@mstruebing mstruebing left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a small nitpick regarding the documentation.
I think in the future it would be great to have some kind of configuration file where some could specify which checks to skip instead of doing it every time when calling the program.
But that's something for later.

Otherwise, great work I really like that PR 🚀

And sorry for taking so long with that review :)

@mgrachev mgrachev merged commit d38aca6 into master May 23, 2020
@mgrachev mgrachev deleted the skip-checks branch May 23, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mstruebing mstruebing mstruebing approved these changes

Assignees

No one assigned

Labels

feature New feature or request

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

disabling rules ?

3 participants

@mgrachev @codecov-commenter @mstruebing