KEMBAR78
Resolves replace `String` with `&'a str` by iamsaquib8 · Pull Request #192 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Resolves replace String with &'a str #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2020
Merged

Resolves replace String with &'a str #192

merged 3 commits into from
May 20, 2020

Conversation

@iamsaquib8
Copy link
Contributor

@iamsaquib8 iamsaquib8 commented May 20, 2020 •
edited
Loading

✔ Checklist:

  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated (for bug fixes / features).

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2020 •
edited
Loading

Codecov Report

Merging #192 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage   97.28%   97.28%   -0.01%     
==========================================
  Files          14       14              
  Lines        1105     1103       -2     
==========================================
- Hits         1075     1073       -2     
  Misses         30       30
Impacted Files Coverage Δ
src/checks/duplicated_key.rs 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2503af2...8c98e82. Read the comment docs.

@iamsaquib8
Copy link
Contributor Author

#181

mgrachev
mgrachev reviewed May 20, 2020
View reviewed changes
Copy link
Member

@mgrachev mgrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamsaquib 👋Thank you for your contribution! 👍

I have left a comment. Could you please fix it?

@mgrachev mgrachev linked an issue May 20, 2020 that may be closed by this pull request
DuplicatedKeyChecker: Replace String with &'a str #181
Closed
@iamsaquib8
Copy link
Contributor Author

Sure

@iamsaquib8 @mgrachev
Update CHANGELOG.md
8c98e82 
Co-authored-by: Grachev Mikhail <work@mgrachev.com>
@mgrachev mgrachev merged commit a662e57 into dotenv-linter:master May 20, 2020
@mgrachev
Copy link
Member

@iamsaquib Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DuplicatedKeyChecker: Replace String with &'a str

4 participants

@iamsaquib8 @codecov-commenter @mgrachev @thenerdovert