Updated lifetimes in EndingBlankLineChecker #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 14 14
Lines 1096 1096
=======================================
Hits 1060 1060
Misses 36 36
Continue to review full report at Codecov.
|
mgrachev
reviewed
May 23, 2020
There was a problem hiding this comment.
@rossjones 👋Thank you for your contribution! 👍
I have left a comment. Please, fix it.
Changes the lifetimes from 'static to 'a
rossjones
force-pushed
the
185-ending-blank-line-replace-static
branch
from
e1c9e07 to
951edd1
Compare
mgrachev
reviewed
May 23, 2020
Fix the text of the pull request link in changelog. Co-authored-by: Grachev Mikhail <work@mgrachev.com>
mgrachev
approved these changes
May 23, 2020
|
@rossjones Great work! Thank you! ❤️ 🙏If it’s not difficult for you, please support the project - click on the star on GitHub ⭐️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the lifetimes from 'static to 'a in EndingBlankLineChecker
Fixes #185
✔ Checklist: