KEMBAR78
Updated lifetimes in LeadingCharacterChecker by rossjones · Pull Request #200 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Conversation

@rossjones
Copy link
Contributor

@rossjones rossjones commented May 23, 2020

Changes the lifetimes from 'static to 'a in LeadingCharacterChecker.
Fixes #188

✔ Checklist:

  • This PR has been added to CHANGELOG.md (at the top of the list);

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2020

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   96.71%   96.71%           
=======================================
  Files          14       14           
  Lines        1096     1096           
=======================================
  Hits         1060     1060           
  Misses         36       36           
Impacted Files Coverage Δ
src/checks/leading_character.rs 96.47% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7cfb5f...69bba64. Read the comment docs.

rossjones added 2 commits May 23, 2020 15:15
Changes the lifetimes from 'static to 'a in LeadingCharacterChecker.
Fixes dotenv-linter#188
@rossjones rossjones force-pushed the 188-leading-character-checker-replace-static branch from ff91f81 to 69bba64 Compare May 23, 2020 14:15
Copy link
Member

@mstruebing mstruebing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🚀

@mgrachev mgrachev merged commit 2cfc8e0 into dotenv-linter:master May 23, 2020
@mgrachev
Copy link
Member

@rossjones Good job! Thanks! 👍

@rossjones rossjones deleted the 188-leading-character-checker-replace-static branch May 23, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

LeadingCharacterChecker: Replace &'static str with &'a str

4 participants