Replace PathBuf with FileEntry for LineEntry #203
Conversation
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
==========================================
+ Coverage 96.34% 96.87% +0.52%
==========================================
Files 14 14
Lines 1178 1377 +199
==========================================
+ Hits 1135 1334 +199
Misses 43 43
Continue to review full report at Codecov.
|
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
mgrachev
changed the title
| pub struct LineEntry { | ||
| pub number: usize, | ||
| pub file_path: PathBuf, | ||
| pub file: FileEntry, |
There was a problem hiding this comment.
This is a great solution!
But what do you think about the use of reference to FileEntry?
This will allow him not to clone and refer to 1 entity.
I look towards Rc<FileEntry> or reference with lifetime, but maybe this is not the best solution.
There was a problem hiding this comment.
It would be great, but right now I don't know how to implement it with less code.
Maybe I will do it later or you may help me with it 😉
What do you think about it?
There was a problem hiding this comment.
It would be great, but right now I don't know how to implement it with less code.
Maybe I will do it later or you may help me with it wink
What do you think about it?
Manually setting the lifetime really seems rather complicated in this case, Rc seems to be a faster option, but there are still a lot of changes in the code ...
I tried to implement everything on Rc and it's really big changes, but fortunately, all the tests pass, but I do not risk doing a pull request out of expediency 😱
I propose to accept your option and possibly revise it in future iterations if need.
3 participants
✔ Checklist: