EndingBlankLineChecker: refactor last line check logic #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
==========================================
- Coverage 96.76% 96.57% -0.19%
==========================================
Files 15 15
Lines 1422 1431 +9
==========================================
+ Hits 1376 1382 +6
- Misses 46 49 +3
Continue to review full report at Codecov.
|
|
@DDtKey Thank you for your contribution! 🔥 I need a bit more time to review your PR. |
Thanks so much for the comments! |
mgrachev
approved these changes
Jun 8, 2020
|
@DDtKey Excellent work! Thank you! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fact, this refactoring was not as trivial as it seemed 😅
In the end, I came to the conclusion that read a file into memory and a small change in the logic of creating
FileEntrycan be useful (for example, reuse, without re-reading).Files are processed in turn and accordingly there will not be more than one file in RAM.
In any case, we stored all the lines for the 1st file in memory before (
Vec<LineEntry>).But, in a similar way, we can easily count in memory the necessary number of lines and then use them for their intended purpose.
Thanks @evgeniy-r for the idea.
Also, the reading of the lines was made in
FileEntry, because, it seems to me, this is more consistent with the principle of single responsibility, instead of the extensive functions oflib.rsI will be glad to discuss your suggestions and comments!
✔ Checklist: