Fix for the case when many extra lines #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
+ Coverage 96.87% 96.89% +0.02%
==========================================
Files 14 14
Lines 1377 1387 +10
==========================================
+ Hits 1334 1344 +10
Misses 43 43
Continue to review full report at Codecov.
|
evgeniy-r
force-pushed
the
fix/three_extra_lines
branch
from
6a2bf0d to
6894d62
Compare
evgeniy-r
force-pushed
the
fix/three_extra_lines
branch
from
6894d62 to
e974140
Compare
evgeniy-r
changed the title
mgrachev
approved these changes
May 29, 2020
|
@evgeniy-r Great work! Thank you! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the small bug in the
ExtraBlankLinecheck: it prints less warnings than expected when there are several successive blank lines.For example, it prints only one warning for this file (instead of two):
✔ Checklist: