KEMBAR78
Enable checks for outside current directory (#179) by tisorlawan · Pull Request #209 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Enable checks for outside current directory (#179) #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 9, 2020
Merged

Enable checks for outside current directory (#179) #209

merged 5 commits into from
Jun 9, 2020

Conversation

@tisorlawan
Copy link
Contributor

@tisorlawan tisorlawan commented Jun 6, 2020 •
edited
Loading

✔ Checklist:

  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated (for bug fixes / features).

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2020 •
edited
Loading

Codecov Report

Merging #209 into master will decrease coverage by 0.00%.
The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
- Coverage   96.57%   96.56%   -0.01%     
==========================================
  Files          15       15              
  Lines        1431     1457      +26     
==========================================
+ Hits         1382     1407      +25     
- Misses         49       50       +1
Impacted Files Coverage Δ
src/lib.rs 90.32% <96.77%> (+2.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f9b41...73d6d41. Read the comment docs.

@mgrachev mgrachev linked an issue Jun 8, 2020 that may be closed by this pull request
Check files not from the current directory #179
Closed
mgrachev
mgrachev reviewed Jun 8, 2020
View reviewed changes
Copy link
Member

@mgrachev mgrachev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tisorlawan 👋 Thank you for your contribution! 🚀

I have left some comments. Please, look at them.

And I see a conflict. Could you resolve it?

mgrachev
mgrachev previously approved these changes Jun 9, 2020
View reviewed changes
@mgrachev mgrachev merged commit 8535822 into dotenv-linter:master Jun 9, 2020
@mgrachev
Copy link
Member

mgrachev commented Jun 9, 2020

@tisorlawan Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Check files not from the current directory

3 participants

@tisorlawan @codecov-commenter @mgrachev