KEMBAR78
Add windows publishing to release workflow by DDtKey · Pull Request #211 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Conversation

DDtKey
Copy link
Member

@DDtKey DDtKey commented Jun 10, 2020

How do you look at adding a build for Windows to release builds?
I think this could be useful, or at least not superfluous.

I created a simple workflow job creating a zip archive with an executable file(.exe) for the target platform.
Perhaps in the future for these purposes it is worth thinking about msi.

✔ Checklist:

  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Docs have been added / updated (for bug fixes / features).

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2020

Codecov Report

Merging #211 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #211   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files          15       15           
  Lines        1457     1457           
=======================================
  Hits         1407     1407           
  Misses         50       50           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e7b7d...a666864. Read the comment docs.

@mgrachev
Copy link
Member

mgrachev commented Jun 11, 2020

@DDtKey It's a good idea! Thank you!

But, I'm not sure if dotenv-linter works on Windows or not.
I can't check it because I don't have any computers on Windows.

@DDtKey
Copy link
Member Author

DDtKey commented Jun 11, 2020

@DDtKey It's a good idea! Thank you!

But, I'm not sure if dotenv-linter works on Windows or not.
I can't check it because I don't have any computers on Windows.

I think it should work.
But definitely, I need to check, today I will use one of my laptops, check dotenv-linter for Windows.

@mgrachev
Copy link
Member

Thank you!
I think we should wait with these changes until the next release after v2.0.0.
I will open an issue to keep all things related with Windows support in one place.

@mgrachev mgrachev mentioned this pull request Jun 11, 2020
10 tasks
@mgrachev
Copy link
Member

@DDtKey I will be glad to discuss any your suggestions there #212

@mgrachev mgrachev added this to the v2.1.0 milestone Jun 11, 2020
@mgrachev mgrachev added the wait Wait for something label Jun 11, 2020
@DDtKey
Copy link
Member Author

DDtKey commented Jun 11, 2020

@DDtKey I will be glad to discuss any your suggestions there #212

Thank you! I will gladly share the results of the tests there.

@DDtKey
Copy link
Member Author

DDtKey commented Jun 11, 2020

It would be nice to configure, besides the portable archive (zip), the msi installer as an additional step in the job.
To do this, you can use WIX-Tools as far as I know, and it come with a Windows environment for github.

Unfortunately, I'm not strong at this, so maybe someone will also help.

@mgrachev
Copy link
Member

What do you think about using Scoop instead of msi?

@DDtKey
Copy link
Member Author

DDtKey commented Jun 11, 2020

What do you think about using Scoop instead of msi?

It looks really more user friendly, a good idea! 🚀

In addition, we can consider the recently released WinGet from Microsoft, which in fact is an alternative to AppGet.

But Scoop looks more suitable and simple for me, I would stay on it for now.

@DDtKey
Copy link
Member Author

DDtKey commented Jun 12, 2020

At the moment, WinGet doesn't support install .zip archives, but exists issue and when (if?) the feature is added, we can create additional manifest.

For now, I have added Scoop manifest to repository with auto-update configuration starting from the delivered version 2.1.0.

@mgrachev
Copy link
Member

I've added a separate repository to store the Scoop manifest - dotenv-linter/scoop#1

@DDtKey
Copy link
Member Author

DDtKey commented Jun 18, 2020

I've added a separate repository to store the Scoop manifest - dotenv-linter/scoop#1

Thanks a lot! I like this option too 🚀

@mgrachev mgrachev merged commit e806d90 into dotenv-linter:master Jun 18, 2020
@mgrachev
Copy link
Member

@DDtKey You have done excellent work! 🚀 Thank you so much for your help with Windows support! ❤️

I'd like to invite you to join the @dotenv-linter organization on GitHub. What do you think about it?

@DDtKey
Copy link
Member Author

DDtKey commented Jun 18, 2020

@DDtKey You have done excellent work! rocket Thank you so much for your help with Windows support! heart

I'd like to invite you to join the @dotenv-linter organization on GitHub. What do you think about it?

Thank you, I don't mind and will be happy to continue to participate in the development of dotenv-linter anyway! 😊

@mgrachev
Copy link
Member

Thank you, I don't mind and will be happy to continue to participate in the development of dotenv-linter anyway! 😊

Cool! I've sent you invitation 🦀

@mgrachev mgrachev mentioned this pull request Jun 18, 2020
5 tasks
@DDtKey DDtKey deleted the windows-release branch June 22, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wait Wait for something

Development

Successfully merging this pull request may close these issues.

3 participants