KEMBAR78
Add build and test steps running on Windows by mgrachev · Pull Request #216 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Add build and test steps running on Windows #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2020
Merged

Add build and test steps running on Windows #216

merged 1 commit into from
Jun 17, 2020

Conversation

@mgrachev
Copy link
Member

@mgrachev mgrachev commented Jun 17, 2020 •
edited
Loading

✔ Checklist:

  • This PR has been added to CHANGELOG.md (at the top of the list).

@mgrachev mgrachev force-pushed the add-windows-build-n-test branch 3 times, most recently from de4e396 to 814d942 Compare June 17, 2020 11:11
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020 •
edited
Loading

Codecov Report

Merging #216 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #216   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files          15       15           
  Lines        1457     1457           
=======================================
  Hits         1407     1407           
  Misses         50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e7b7d...bc4e16c. Read the comment docs.

@mgrachev mgrachev force-pushed the add-windows-build-n-test branch 3 times, most recently from f30dafd to 2a4b231 Compare June 17, 2020 11:18
@DDtKey
Copy link
Member

DDtKey commented Jun 17, 2020

This is exactly what we need! 🚀
The tests did not pass precisely because of the UNC, which solves #213

@mgrachev mgrachev changed the title Add build and tetst steps runnning on Windows Add build and test steps runnning on Windows Jun 17, 2020
@mgrachev mgrachev changed the title Add build and test steps runnning on Windows Add build and test steps running on Windows Jun 17, 2020
@mgrachev
Add build and test steps running on Windows
33a3b58 
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@mgrachev mgrachev force-pushed the add-windows-build-n-test branch from 2a4b231 to 33a3b58 Compare June 17, 2020 11:40
@mgrachev mgrachev merged commit 5dc8d05 into master Jun 17, 2020
@mgrachev mgrachev deleted the add-windows-build-n-test branch June 17, 2020 11:41
@mgrachev mgrachev mentioned this pull request Jun 17, 2020
Closed
10 tasks
@mgrachev mgrachev linked an issue Jun 17, 2020 that may be closed by this pull request
Support Windows #212
Closed
10 tasks
@mgrachev mgrachev removed a link to an issue Jun 17, 2020
Support Windows #212
Closed
10 tasks
@mgrachev mgrachev mentioned this pull request Jun 18, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgrachev @codecov-commenter @DDtKey