Move show-checks flag to main.rs #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDtKey
reviewed
Jun 29, 2020
DDtKey
reviewed
Jun 29, 2020
DDtKey
reviewed
Jun 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
- Coverage 96.66% 96.58% -0.08%
==========================================
Files 16 16
Lines 1499 1495 -4
==========================================
- Hits 1449 1444 -5
- Misses 50 51 +1
Continue to review full report at Codecov.
|
DDtKey
requested changes
Jun 29, 2020
DDtKey
reviewed
Jun 29, 2020
|
It’s a good idea to leave terminal operations in main.rs! 🚀 |
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
mgrachev
force-pushed
the
main-refactoring
branch
from
3abb4ce to
f3b0346
Compare
DDtKey
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have been done:
available_check_namesmethod, because all checks are already in alphabetical order;show checksflag is moved tomain.rsfile, because it allowed to exit from the program.✔ Checklist: