KEMBAR78
Add support of comments to disable checks by mgrachev · Pull Request #239 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Add support of comments to disable checks #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 21, 2020
Merged

Add support of comments to disable checks #239

merged 4 commits into from
Aug 21, 2020

Conversation

mgrachev
Copy link
Member

@mgrachev mgrachev commented Jul 14, 2020 •
edited
Loading

✔ Checklist:

  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated (for bug fixes / features).

@mgrachev mgrachev linked an issue Jul 14, 2020 that may be closed by this pull request
Proposal: Control comments #237
Closed
@mgrachev mgrachev added this to the v2.2.0 milestone Jul 14, 2020
@mgrachev mgrachev changed the title Add controll comments Add control comments Aug 14, 2020
@mgrachev mgrachev changed the title Add control comments Add support of comments to disable checks Aug 14, 2020
@mgrachev mgrachev marked this pull request as ready for review August 14, 2020 19:49
@mgrachev mgrachev requested a review from a team August 14, 2020 19:50
DDtKey
DDtKey reviewed Aug 20, 2020
View reviewed changes
Copy link
Member

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thank you! 👍

I left a some comments, please see them.

@mgrachev
Add support of comments to disable checks
fa6143c 
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@mgrachev
Merge branch 'master' of github.com:mgrachev/dotenv-linter into skip_…
f3c7bf5 
…comments

Signed-off-by: Mikhail Grachev <work@mgrachev.com>

# Conflicts:
#	README.md
#	docs/quick_start.md
@mgrachev mgrachev requested review from a team and DDtKey August 20, 2020 15:18
DDtKey
DDtKey reviewed Aug 20, 2020
View reviewed changes
@mgrachev
Move comment module into common
10da305 
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@mgrachev mgrachev requested review from a team and DDtKey August 21, 2020 10:20
DDtKey
DDtKey approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mgrachev mgrachev merged commit d9c9458 into master Aug 21, 2020
@mgrachev mgrachev deleted the skip_comments branch August 21, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DDtKey DDtKey DDtKey approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

v2.2.0

Development

Successfully merging this pull request may close these issues.

Proposal: Control comments

2 participants

@mgrachev @DDtKey