KEMBAR78
Add total problems to output and --quiet argument by mgrachev · Pull Request #242 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Add total problems to output and --quiet argument #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 10, 2020
Merged

Add total problems to output and --quiet argument #242

merged 8 commits into from
Aug 10, 2020

Conversation

mgrachev
Copy link
Member

@mgrachev mgrachev commented Aug 5, 2020 •
edited
Loading

This PR originates from #240.
I decided to add an additional flag to be able not to display verbose information such as "Found n problems".
In #240 PR uses the flag --no-color for this, but I think we should add the additional flag --quiet.

✔ Checklist:

  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated (for bug fixes / features).

@mgrachev mgrachev changed the title Add quiet argument Add --quiet argument Aug 5, 2020
@mgrachev
Add --quiet argument
ffebb70 
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
mgrachev added 4 commits August 5, 2020 19:18
@mgrachev
Merge branch 'master' of github.com:mgrachev/dotenv-linter into add-q…
0b5dca6 
…uiet-arg
@mgrachev
Update docs
4e1151a 
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@mgrachev
Fix warnings
417c79c 
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@mgrachev
Update tests
b406006 
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@mgrachev mgrachev requested review from DDtKey and mstruebing and removed request for DDtKey August 5, 2020 17:36
@mgrachev mgrachev mentioned this pull request Aug 5, 2020
Closed
3 tasks
@mgrachev mgrachev added this to the v2.2.0 milestone Aug 5, 2020
@mgrachev
Update changelog
925d0b3 
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
DDtKey
DDtKey previously approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea to make a separate flag to control additional output 🚀

The only thing I would point out is that this PR adds not only the --quiet flag, but also the additional output itself 😂

wesleimp
wesleimp previously approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@wesleimp wesleimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@mgrachev mgrachev dismissed stale reviews from wesleimp and DDtKey via 687dadd August 6, 2020 18:11
@mgrachev
Some fixes
21982ae 
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@mgrachev mgrachev changed the title Add --quiet argument Add total problems to output and --quiet argument Aug 7, 2020
@mgrachev mgrachev requested a review from DDtKey August 7, 2020 11:03
@mgrachev
Copy link
Member Author

mgrachev commented Aug 7, 2020 •
edited
Loading

The only thing I would point out is that this PR adds not only the --quiet flag, but also the additional output itself 😂

Fixed 😃

@mgrachev
Copy link
Member Author

mgrachev commented Aug 10, 2020 •
edited
Loading

@dotenv-linter/core Need your approval again 🙂

DDtKey
DDtKey approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mgrachev mgrachev merged commit 14d8208 into master Aug 10, 2020
@mgrachev mgrachev deleted the add-quiet-arg branch August 10, 2020 13:57
@mgrachev mgrachev mentioned this pull request Aug 11, 2020
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DDtKey DDtKey DDtKey approved these changes

@mstruebing mstruebing Awaiting requested review from mstruebing

+1 more reviewer

@wesleimp wesleimp wesleimp left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

v2.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mgrachev @DDtKey @wesleimp