Add trailing whitespace fix #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `TrailingWhitespaceFixer` and included it in the `fixlist`. Update `unfixed_warnings` and `multiple_files` tests to reflect the new fix and to use `ExtraBlankLine` as an unfixed warning example.
|
I'm willing to add something to the docs, but I'm not sure what the vision for that looks like since there isn't a doc for the |
mgrachev
reviewed
Aug 11, 2020
There was a problem hiding this comment.
@gregcline 👋 Thank you for your contribution! 🚀
Can you add an additional integration test for this fixer?
For example: https://github.com/dotenv-linter/dotenv-linter/blob/master/tests/fixes/space_character.rs
mgrachev
approved these changes
Aug 13, 2020
|
@gregcline Thank you! 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
TrailingWhitespaceFixerand included it in thefixlist.Update
unfixed_warningsandmultiple_filestests to reflect the newfix and to use
ExtraBlankLineas an unfixed warning example.✔ Checklist: