KEMBAR78
Implement trait `Fix` for warnings issued by `QuoteCharacterChecker`. by lensvol · Pull Request #257 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Implement trait Fix for warnings issued by QuoteCharacterChecker. #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 14, 2020
Merged

Implement trait Fix for warnings issued by QuoteCharacterChecker. #257

merged 13 commits into from
Aug 14, 2020

Conversation

lensvol
Copy link
Contributor

@lensvol lensvol commented Aug 11, 2020 •
edited
Loading

Closes #249.

✔ Checklist:

  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);

DDtKey
DDtKey reviewed Aug 12, 2020
View reviewed changes
Copy link
Member

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for your contribution! 🚀
I left comment about Fixer, please look at this.

And it will be good, if you add an integration test, for example: https://github.com/dotenv-linter/dotenv-linter/blob/master/tests/fixes/space_character.rs

DDtKey
DDtKey reviewed Aug 12, 2020
View reviewed changes
DDtKey
DDtKey reviewed Aug 12, 2020
View reviewed changes
@DDtKey DDtKey requested a review from a team August 12, 2020 10:43
mgrachev
mgrachev reviewed Aug 14, 2020
View reviewed changes
@mgrachev mgrachev requested a review from DDtKey August 14, 2020 09:36
@mgrachev mgrachev requested a review from a team August 14, 2020 11:21
DDtKey
DDtKey previously approved these changes Aug 14, 2020
View reviewed changes
DDtKey
DDtKey reviewed Aug 14, 2020
View reviewed changes
@mgrachev mgrachev requested review from a team and DDtKey August 14, 2020 12:24
@DDtKey DDtKey merged commit 612e1a9 into dotenv-linter:master Aug 14, 2020
@lensvol lensvol deleted the quote-char-fixer branch August 14, 2020 12:56
@mgrachev
Copy link
Member

mgrachev commented Aug 14, 2020 •
edited
Loading

@lensvol Thank you for your help! 🔥

@mgrachev
Copy link
Member

🙏 If it’s not difficult for you, please support the project - click on the star on GitHub ⭐️

@lensvol
Copy link
Contributor Author

lensvol commented Aug 14, 2020

My pleasure 🍷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

@DDtKey DDtKey DDtKey approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add fixer: QuoteCharacterFixer

3 participants

@lensvol @mgrachev @DDtKey