IncorrectDelimiter fixer (#246) #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gillespiecd
force-pushed
the
delimiter-fixer
branch
2 times, most recently
from
c82e24d to
db901e8
Compare
Codecov Report
@@ Coverage Diff @@
## master #258 +/- ##
==========================================
- Coverage 97.17% 95.76% -1.42%
==========================================
Files 26 27 +1
Lines 2055 2125 +70
==========================================
+ Hits 1997 2035 +38
- Misses 58 90 +32
Continue to review full report at Codecov.
|
DDtKey
previously approved these changes
Aug 14, 2020
DDtKey
reviewed
Aug 14, 2020
gillespiecd
force-pushed
the
delimiter-fixer
branch
4 times, most recently
from
17775b3 to
500d693
Compare
DDtKey
reviewed
Aug 20, 2020
gillespiecd
force-pushed
the
delimiter-fixer
branch
8 times, most recently
from
789f720 to
4806ad2
Compare
mgrachev
reviewed
Aug 21, 2020
gillespiecd
force-pushed
the
delimiter-fixer
branch
2 times, most recently
from
98061e6 to
86bf6f8
Compare
gillespiecd
force-pushed
the
delimiter-fixer
branch
from
86bf6f8 to
c34f5de
Compare
mgrachev
reviewed
Aug 22, 2020
gillespiecd
force-pushed
the
delimiter-fixer
branch
2 times, most recently
from
e04edbf to
ad32989
Compare
2 tasks
gillespiecd
force-pushed
the
delimiter-fixer
branch
from
ad32989 to
7b9e27a
Compare
mgrachev
reviewed
Aug 22, 2020
gillespiecd
force-pushed
the
delimiter-fixer
branch
from
7b9e27a to
3b9028e
Compare
mgrachev
approved these changes
Aug 23, 2020
|
@gillespiecd Great job! Thank you! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #246
I followed the same logic used in the checker, to keep it consistent.
✔ Checklist: