KEMBAR78
add ExtraBlankLineFixer (#260) by diggymo · Pull Request #260 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Conversation

diggymo
Copy link
Contributor

@diggymo diggymo commented Aug 14, 2020

#245

Below are the points I would like you to check in particular.

  • Unnecessary function (test_command_fix_fail) came out, was it better to delete it?

✔ Checklist:

  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);

@diggymo diggymo changed the title add ExtraBlankLineFixer (#245) add ExtraBlankLineFixer (#260) Aug 14, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2020

Codecov Report

Merging #260 into master will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
+ Coverage   97.21%   97.30%   +0.08%     
==========================================
  Files          21       23       +2     
  Lines        1869     2041     +172     
==========================================
+ Hits         1817     1986     +169     
- Misses         52       55       +3     
Impacted Files Coverage Δ
src/fixes.rs 96.84% <ø> (-3.16%) ⬇️
src/fixes/extra_blank_line.rs 100.00% <100.00%> (ø)
src/fixes/quote_character.rs 100.00% <0.00%> (ø)
src/checks/quote_character.rs 96.77% <0.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d326dcd...6f01627. Read the comment docs.

Copy link
Member

@mgrachev mgrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diggymo 👋 Thank you for your contribution! 🚀

I have left some comments. Please look at them 👀

@diggymo
Copy link
Contributor Author

diggymo commented Aug 19, 2020

I'm sorry for immature. I fixed thone now.

mgrachev
mgrachev previously approved these changes Aug 19, 2020
Copy link
Member

@mgrachev mgrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mgrachev mgrachev requested a review from a team August 19, 2020 17:13
@mgrachev mgrachev linked an issue Aug 19, 2020 that may be closed by this pull request
mgrachev
mgrachev previously approved these changes Aug 20, 2020
@mgrachev mgrachev requested a review from a team August 21, 2020 13:31
@mgrachev mgrachev added this to the v2.2.0 milestone Aug 21, 2020
@mgrachev
Copy link
Member

@diggymo Please, update your PR from the master branch.

@diggymo
Copy link
Contributor Author

diggymo commented Aug 27, 2020

@diggymo Please, update your PR from the master branch.

Sorry for being late. Just fixed.

@mgrachev mgrachev merged commit 9e82ddc into dotenv-linter:master Aug 27, 2020
@mgrachev
Copy link
Member

@diggymo Thanks a lot! You're awesome! 🔥

🙏 If it’s not difficult for you, please support the project - click on the star on GitHub ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Add fixer: ExtraBlankLineFixer

4 participants