KEMBAR78
Actions uses cache@v2 by gillespiecd · Pull Request #262 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Actions uses cache@v2 #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2020
Merged

Actions uses cache@v2 #262

merged 2 commits into from
Aug 20, 2020

Conversation

gillespiecd
Copy link
Contributor

@gillespiecd gillespiecd commented Aug 15, 2020 •
edited
Loading

Closes #231

Updated to use the new cache version:

  1. Use multiple cargo paths in the same block
  2. Cache the grcov binary

✔ Checklist:

  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated (for bug fixes / features).

@gillespiecd gillespiecd marked this pull request as ready for review August 15, 2020 21:27
mstruebing
mstruebing previously approved these changes Aug 16, 2020
View reviewed changes
Copy link
Member

@mstruebing mstruebing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you for your PR 🚀

@mgrachev
Copy link
Member

mgrachev commented Aug 17, 2020 •
edited
Loading

@gillespiecd 👋 Thank you for your contribution! 👍

The new version of the cache action supports the path key as an array.
Please use it instead of using multiple cache actions at each step.

@mgrachev
Copy link
Member

mgrachev commented Aug 17, 2020 •
edited
Loading

@mgrachev I'd love to take credit for it, but it wasn't me :D

I'm very sorry that I disturbed you 😅

@evgeniy-r
Copy link
Contributor

Also v2 supports single file caches, so we can handle the Grcov executable more easily.

@gillespiecd gillespiecd force-pushed the actions-cache branch 7 times, most recently from 5fd8885 to 106a257 Compare August 17, 2020 20:33
@codecov-commenter
Copy link

Codecov Report

Merging #262 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   97.30%   97.30%           
=======================================
  Files          22       22           
  Lines        1930     1930           
=======================================
  Hits         1878     1878           
  Misses         52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 612e1a9...2437783. Read the comment docs.

@gillespiecd
Copy link
Contributor Author

Thanks for the suggestions, I've gone ahead and added the requested changes. I'm still new to using GH actions, but it looks to be working correctly.

evgeniy-r
evgeniy-r reviewed Aug 18, 2020
View reviewed changes
@gillespiecd gillespiecd force-pushed the actions-cache branch 3 times, most recently from a649475 to 9a30ef6 Compare August 18, 2020 20:01
@mgrachev mgrachev requested a review from a team August 19, 2020 08:55
mgrachev
mgrachev reviewed Aug 19, 2020
View reviewed changes
evgeniy-r
evgeniy-r reviewed Aug 19, 2020
View reviewed changes
@gillespiecd
Actions uses cache@v2 (dotenv-linter#231)
15bc249 
* Cache multiple paths in the same block
* Cache grcov binary
@gillespiecd
Copy link
Contributor Author

Thanks for being patient with the review and working through some beginner mistakes with GH actions, hopefully it is looking good now 👍

mgrachev
mgrachev previously approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@mgrachev mgrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mgrachev mgrachev requested a review from a team August 19, 2020 16:04
evgeniy-r
evgeniy-r previously approved these changes Aug 20, 2020
View reviewed changes
@mgrachev mgrachev dismissed stale reviews from evgeniy-r and themself via 4ac8d73 August 20, 2020 17:54
@mgrachev mgrachev merged commit fb6643f into dotenv-linter:master Aug 20, 2020
@mgrachev
Copy link
Member

@gillespiecd Thanks a lot! You're awesome! ❤️

@gillespiecd gillespiecd deleted the actions-cache branch August 20, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

@mstruebing mstruebing mstruebing left review comments

+1 more reviewer

@evgeniy-r evgeniy-r evgeniy-r left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update actions/cache to v2

5 participants

@gillespiecd @mgrachev @evgeniy-r @codecov-commenter @mstruebing