KEMBAR78
Implement EndingBlankLineFixer by baile320 · Pull Request #263 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Conversation

@baile320
Copy link
Contributor

@baile320 baile320 commented Aug 16, 2020

Implements a fixer to add trailing blank lines to files.

Closes: #244 (see that thread for some minor discussion on approach).

✔ Checklist:

  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated (for bug fixes / features).

@baile320 baile320 marked this pull request as ready for review August 16, 2020 13:16
Copy link
Member

@mgrachev mgrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baile320 Thank you for your contribution! 🦀

I have left some comments. Please look at them 👀

@baile320 baile320 requested a review from mgrachev August 19, 2020 18:08
@mgrachev mgrachev requested a review from a team August 20, 2020 08:23
@mgrachev mgrachev requested a review from a team August 20, 2020 16:04
mgrachev
mgrachev previously approved these changes Aug 20, 2020
Copy link
Member

@mgrachev mgrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mgrachev mgrachev requested a review from DDtKey August 20, 2020 16:09
DDtKey
DDtKey previously approved these changes Aug 20, 2020
@mgrachev mgrachev dismissed stale reviews from DDtKey and themself via 414d4a8 August 20, 2020 19:36
@mgrachev mgrachev merged commit 6005dbc into dotenv-linter:master Aug 20, 2020
@mgrachev
Copy link
Member

@baile320 Thanks a lot! You're awesome! ❤️

🙏 If it’s not difficult for you, please support the project - click on the star on GitHub ⭐️

@DDtKey DDtKey mentioned this pull request Aug 27, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Add fixer: EndingBlankLineFixer

3 participants