KEMBAR78
Test for fix_warnings by kilotaras · Pull Request #266 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Conversation

kilotaras
Copy link
Contributor

@kilotaras kilotaras commented Aug 17, 2020

Added tests that verify that default implementation of fix_warnings correctly marks warnings as fixed/not_fixed depending on result of fix_line

✔ Checklist:

  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated (for bug fixes / features).

Unsure if checklist apply.

@mgrachev
Copy link
Member

mgrachev commented Aug 18, 2020

@kilotaras 👋 Thank you for your contribution! ✌️

Please add your PR to CHANGELOG.md.

@codecov-commenter
Copy link

Codecov Report

Merging #266 into master will decrease coverage by 0.12%.
The diff coverage is 86.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
- Coverage   97.30%   97.18%   -0.13%     
==========================================
  Files          22       22              
  Lines        1930     1952      +22     
==========================================
+ Hits         1878     1897      +19     
- Misses         52       55       +3     
Impacted Files Coverage Δ
src/fixes.rs 97.34% <86.36%> (-2.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ba983f...1e3e352. Read the comment docs.

kilotaras and others added 3 commits August 18, 2020 18:33
Added tests that verify that default implementation of fix_warnings
correctly marks warnings as fixed/not_fixed depending on result of
fix_line
@mgrachev mgrachev merged commit 0cebfe3 into dotenv-linter:master Aug 18, 2020
@mgrachev
Copy link
Member

@kilotaras Thank you! 👍

🙏 If it’s not difficult for you, please support the project - click on the star on GitHub ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants