Update logic for IncorrectDelimiterChecker #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 19, 2020
gillespiecd
reviewed
Aug 19, 2020
DDtKey
reviewed
Aug 20, 2020
|
Thanks everyone for your patience! I have made the requested changes. |
|
@baile320 Thanks a lot! You're awesome! ❤️ 🙏 If it’s not difficult for you, please support the project - click on the star on GitHub ⭐️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into issues with IncorrectDelimiterChecker: it thought, for example, "*FOO=BAR" had an incorrect delimiter (this type of error will ultimately fixed by LeadingCharacterFixer, see: #259). IMO, that is not a delimiter at all, since delimiters should occur /between/ other characters, so I updated the logic of this checker and updated some of the tests & added new ones.
✔ Checklist: