Partition fixed/unfixed warnings #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrachev
previously approved these changes
Aug 29, 2020
mgrachev
reviewed
Aug 29, 2020
There was a problem hiding this comment.
@gillespiecd Thank you for your participation! 🦀
Please do everything from the checklist:
- This PR has been added to CHANGELOG.md (at the top of the list);
|
Done, should have prepped that beforehand 🧹 |
mgrachev
approved these changes
Aug 29, 2020
|
@gillespiecd Thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partitionclosure.In my opinion, this seems clearer to read and more idiomatic than running two separate filter iterations.
✔ Checklist: