KEMBAR78
Finishing autofix by evgeniy-r · Pull Request #287 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Finishing autofix #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 28, 2020
Merged

Finishing autofix #287

merged 5 commits into from
Sep 28, 2020

Conversation

@evgeniy-r
Copy link
Contributor

@evgeniy-r evgeniy-r commented Sep 26, 2020 •
edited
Loading

This PR fixes the issue #285.
There is a little duplication, but I think that is OK for now.

As far as I can see, the autofix feature is finally completed.

✔ Checklist:

  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features).

@evgeniy-r evgeniy-r force-pushed the feat/285/finish_autofix branch from 9965e51 to ad775a5 Compare September 26, 2020 08:48
@codecov-commenter
Copy link

Codecov Report

Merging #287 into master will decrease coverage by 0.02%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
- Coverage   96.76%   96.74%   -0.03%     
==========================================
  Files          32       32              
  Lines        2195     2240      +45     
==========================================
+ Hits         2124     2167      +43     
- Misses         71       73       +2
Impacted Files Coverage Δ
src/fixes/duplicated_key.rs 96.36% <90.90%> (-3.64%) ⬇️
src/fixes.rs 95.45% <100.00%> (+0.95%) ⬆️
src/lib.rs 95.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36b904e...8b1147e. Read the comment docs.

@evgeniy-r evgeniy-r marked this pull request as ready for review September 26, 2020 11:32
@evgeniy-r
Copy link
Contributor Author

@mgrachev, I remember you mentioned that we should remove the Fixed/Unfixed feature.

I can do this, it will simplify the code.

@mgrachev
Copy link
Member

@mgrachev, I remember you mentioned that we should remove the Fixed/Unfixed feature.

I can do this, it will simplify the code.

I have already done it, but haven't published yet.

@mgrachev mgrachev linked an issue Sep 26, 2020 that may be closed by this pull request
Some fixers can spawn new warnings (e. g. LowercaseKey) #285
Closed
@mgrachev mgrachev requested a review from a team September 28, 2020 08:40
@mgrachev mgrachev added this to the v2.2.0 milestone Sep 28, 2020
mgrachev
mgrachev reviewed Sep 28, 2020
View reviewed changes
Copy link
Member

@mgrachev mgrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evgeniy-r Thank you for your contribution! 👍

I've left some comments. Please look at them 👀

@mgrachev mgrachev requested a review from a team September 28, 2020 10:28
@mgrachev mgrachev merged commit 281a203 into dotenv-linter:master Sep 28, 2020
@mgrachev
Copy link
Member

@evgeniy-r Thanks a lot! 🔥

@evgeniy-r evgeniy-r deleted the feat/285/finish_autofix branch September 28, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

v2.2.0

Development

Successfully merging this pull request may close these issues.

Some fixers can spawn new warnings (e. g. LowercaseKey)

3 participants

@evgeniy-r @codecov-commenter @mgrachev