Add check_output function for integration tests #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Anthuang 👋 Thank you for your contribution! 🚀 Please add this PR to CHANGELOG.md (at the top of the |
mgrachev
approved these changes
Oct 5, 2020
|
@Anthuang Thank you! 👍 🙏 If it’s not difficult for you, please support the project - click on the star on GitHub ⭐️ |
|
I'd be happy to! I'm just starting out in Rust and am looking for projects to contribute to. It seems like all the current issues are taken, is there anything else I can help out with? |
You can take this one #268 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
check_outputfunction for integration tests, and refactors current tests to use it. The added function is made to be similar tofix_output, which already exists.Resolves: #293
✔ Checklist:
- [ ] This PR has been added to CHANGELOG.md (at the top of the list);- [ ] Tests for the changes have been added (for bug fixes / features);- [ ] Docs have been added / updated (for bug fixes / features).Crossed out the above since this is just an internal improvement. Let me know if there's anything else I should do!