Adds additional test for LineEntry.get_value #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvkpd
force-pushed
the
Adds-test-for-getValue-292
branch
from
8c580f3 to
556d55a
Compare
|
@vvkpd 👋 Thank you for your contribution! 🎉 Please add this PR to CHANGELOG.md (at the top of the |
vvkpd
force-pushed
the
Adds-test-for-getValue-292
branch
from
556d55a to
5baacdc
Compare
|
Hey @mgrachev, I made the changes please take a look and review it. |
|
Hey @mgrachev, Background: |
mgrachev
approved these changes
Oct 6, 2020
|
@vvkpd Thank you! 👍 🙏 If it’s not difficult for you, please support the project - click on the star on GitHub ⭐️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✔ Checklist:
Summary of change
adds additional test for get_value method which is in Line_entry.rs
Related issue
Closes #292
Pull request checklist
Please keep this checklist in & ensure you have done the following:
Ensure code changes pass all tests
Filled in the summary, context (if applicable) and related issue section. Replace the square brackets and its placeholder content with your contents. For an example, see any merged in pull request
Created a branch that has a descriptive name (what your branch is for in a few words and includes the issue number at the end, e.g.
test-reading-goal-123Resolved any merge conflicts