KEMBAR78
Feature/add action-yamllint by vk26 · Pull Request #317 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Feature/add action-yamllint #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 15, 2020
Merged

Feature/add action-yamllint #317

merged 5 commits into from
Oct 15, 2020

Conversation

@vk26
Copy link
Contributor

@vk26 vk26 commented Oct 10, 2020 •
edited
Loading

  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated (for bug fixes / features).

@codecov-io
Copy link

codecov-io commented Oct 10, 2020 •
edited
Loading

Codecov Report

Merging #317 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #317   +/-   ##
=======================================
  Coverage   96.98%   96.98%           
=======================================
  Files          32       32           
  Lines        2292     2292           
=======================================
  Hits         2223     2223           
  Misses         69       69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1002b57...e5fe04f. Read the comment docs.

@vk26 vk26 mentioned this pull request Oct 10, 2020
Closed
mgrachev
mgrachev reviewed Oct 10, 2020
View reviewed changes
Copy link
Member

@mgrachev mgrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vk26 👋 Thank you for your contribution! 🚀

I have left some comments. Please look at them 👀

@mgrachev
Copy link
Member

Also, I see some comments from yamllint. Please fix them.

@vk26
Copy link
Contributor Author

vk26 commented Oct 11, 2020

@mgrachev Hi! I fixed it. I had to use key "on" with quotes following yamllint rule about truthy

@mgrachev
Copy link
Member

mgrachev commented Oct 11, 2020 •
edited
Loading

@mgrachev Hi! I fixed it. I had to use key "on" with quotes following yamllint rule about truthy

Thank you! Can we skip this rule using the yamllint_flags option?

@vk26 vk26 force-pushed the feature/add_action-yamllint branch from ee3a80c to e5fe04f Compare October 15, 2020 16:05
@vk26
Copy link
Contributor Author

vk26 commented Oct 15, 2020

@mgrachev Hi! I set in yamllint_flags skipping truthy-rule.

@mgrachev mgrachev linked an issue Oct 15, 2020 that may be closed by this pull request
Add action-yamllint #300
Closed
@mgrachev mgrachev merged commit f6adeec into dotenv-linter:master Oct 15, 2020
@mgrachev
Copy link
Member

@vk26 Thank you! ❤️

@mgrachev mgrachev mentioned this pull request Mar 25, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add action-yamllint

3 participants

@vk26 @codecov-io @mgrachev