KEMBAR78
Added docker build to CI by JoeAmedeo · Pull Request #322 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Conversation

@JoeAmedeo
Copy link
Contributor

@JoeAmedeo JoeAmedeo commented Oct 13, 2020

This PR is intended to add an additional step to the CI action, as a means of detecting docker build errors prior to PR completion.

✔ Checklist:

  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated (for bug fixes / features).

@codecov-io
Copy link

codecov-io commented Oct 13, 2020

Codecov Report

Merging #322 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #322   +/-   ##
=======================================
  Coverage   96.98%   96.98%           
=======================================
  Files          32       32           
  Lines        2292     2292           
=======================================
  Hits         2223     2223           
  Misses         69       69           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43ba265...da37a49. Read the comment docs.

Copy link
Member

@mgrachev mgrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoeAmedeo 👋 Thank you for your contribution! 👍

I have left a comment. Please take a look at it 👀

@mgrachev mgrachev linked an issue Oct 14, 2020 that may be closed by this pull request
@mgrachev mgrachev merged commit 1002b57 into dotenv-linter:master Oct 14, 2020
@mgrachev
Copy link
Member

@JoeAmedeo Thank you! 💪

🙏 If it’s not difficult for you, please support the project - click on the star on GitHub ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Add Dockerfile check to CI

3 participants