#325 Linter rechecks files if they were listed more than once #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrachev
reviewed
Oct 19, 2020
There was a problem hiding this comment.
@Aashu23 👋 Thank you for your contribution! 🚀
I have left a comment. Please take a look 👀
Also, please add two intergration tests to check that all works as expected:
- Case 1
$ dotenv-linter /path1 /path1; - Case 2
$ dotenv-linter /path1 /path1/.env.b.
mgrachev
reviewed
Oct 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
=======================================
Coverage 96.98% 96.98%
=======================================
Files 32 32
Lines 2292 2292
=======================================
Hits 2223 2223
Misses 69 69
Continue to review full report at Codecov.
|
mgrachev
approved these changes
Oct 20, 2020
|
@Aashu23 Thank you! 👍 🙏 If it’s not difficult for you, please support the project - click on the star on GitHub ⭐️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mgrachev
Fixed the issue
Updated tests accordingly
Fixes #325
✔ Checklist: