feat: make an output on-the-fly(#335) #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
==========================================
+ Coverage 97.05% 97.10% +0.04%
==========================================
Files 33 34 +1
Lines 2379 2349 -30
==========================================
- Hits 2309 2281 -28
+ Misses 70 68 -2
Continue to review full report at Codecov.
|
DDtKey
changed the title
# Conflicts: # src/common/output.rs # src/main.rs
mgrachev
reviewed
Nov 9, 2020
mgrachev
approved these changes
Nov 9, 2020
|
@DDtKey Thanks a lot! ⚡️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought about several options(up to the reactive approach, which is overkill in the linter), but it seemed to me that such a solution would be rather transparent and linear in the code.
By and large, the program output itself is completely taken out in a separate module.
Also, the structure of the output was completely preserved and the integration tests remained relevant!
And I noticed that we didn't update the documentation after adding the
checking/fixingfiles output.I will update this here and in a related project (site), but first I wanted to know your opinion on the implementation.
UPD: PR to site
Maybe there are ideas or suggestions with other approaches? @dotenv-linter/core
✔ Checklist: