KEMBAR78
Remade flags to subcommands by mgrachev · Pull Request #342 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Remade flags to subcommands #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2020
Merged

Remade flags to subcommands #342

merged 1 commit into from
Nov 18, 2020

Conversation

@mgrachev
Copy link
Member

@mgrachev mgrachev commented Nov 15, 2020 •
edited
Loading

Close #333

What was done:

  • Remade the --fix/-f flag to the fix subcommand;
  • Remade the --show-checks flag to the list subcommand;
  • Fixed a bug with output for multiple files in quiet mode (and wrote a test for that case);
  • Added colored help output.

✔ Checklist:

  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated (for bug fixes / features).

@mgrachev mgrachev added this to the v3.0.0 milestone Nov 15, 2020
DDtKey
DDtKey reviewed Nov 16, 2020
View reviewed changes
Copy link
Member

@DDtKey DDtKey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very transparent now, thanks for the work done! 🚀
I left a couple of comments, please take a look 🙂

P.S: I also see that this is not yet ready, but I allowed myself to leave comments right now, I hope this can be useful and I do not interfere with the progress of your work 🙏

@codecov-io
Copy link

codecov-io commented Nov 17, 2020 •
edited
Loading

Codecov Report

Merging #342 (15c1c8c) into master (794fce7) will decrease coverage by 0.15%.
The diff coverage is 92.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
- Coverage   97.13%   96.97%   -0.16%     
==========================================
  Files          34       34              
  Lines        2371     2415      +44     
==========================================
+ Hits         2303     2342      +39     
- Misses         68       73       +5
Impacted Files Coverage Δ
src/main.rs 83.72% <84.84%> (+1.57%) ⬆️
src/lib.rs 97.19% <95.55%> (-2.81%) ⬇️
src/common/output/check.rs 100.00% <100.00%> (ø)
src/common/output/fix.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 794fce7...15c1c8c. Read the comment docs.

@mgrachev mgrachev force-pushed the subcommands branch 3 times, most recently from 9ffba32 to e46f741 Compare November 17, 2020 16:18
@mgrachev mgrachev changed the title Subcommands Remade flags to subcommands Nov 17, 2020
@mgrachev mgrachev force-pushed the subcommands branch 5 times, most recently from 4128b73 to 15c1c8c Compare November 17, 2020 16:50
@mgrachev mgrachev marked this pull request as ready for review November 17, 2020 17:07
DDtKey
DDtKey reviewed Nov 17, 2020
View reviewed changes
@mgrachev
refactor!: remade flags to subcommands
554a5e8 
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@mgrachev mgrachev requested a review from DDtKey November 18, 2020 08:42
@mgrachev mgrachev merged commit 4db20d1 into master Nov 18, 2020
@mgrachev mgrachev deleted the subcommands branch November 18, 2020 16:32
@mgrachev mgrachev mentioned this pull request Nov 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DDtKey DDtKey DDtKey approved these changes

@mstruebing mstruebing Awaiting requested review from mstruebing

Assignees

No one assigned

Labels

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

Proposal: Using subcommands intead of flags

3 participants

@mgrachev @codecov-io @DDtKey