KEMBAR78
fix(#345): Find all problems by vbrandl · Pull Request #348 · dotenv-linter/dotenv-linter · GitHub
Skip to content

fix(#345): Find all problems #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 5, 2020
Merged

fix(#345): Find all problems #348

merged 10 commits into from
Dec 5, 2020

Conversation

@vbrandl
Copy link
Contributor

@vbrandl vbrandl commented Dec 4, 2020 •
edited
Loading

This fixes the problems described in #345.

I had to change some tests to make them pass again. Since this is my first commit, I am not quite sure if every change I made is acceptable so this will need some review.

Also I'm not sure if this fix requires any updates on the documentation repo.

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

mgrachev
mgrachev requested changes Dec 4, 2020
View reviewed changes
Copy link
Member

@mgrachev mgrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbrandl 👋 Thank you for your contribution! 🚀

I have left a comment. Please take a look at it 👀

@mgrachev mgrachev added this to the v3.0.0 milestone Dec 4, 2020
@mgrachev mgrachev linked an issue Dec 4, 2020 that may be closed by this pull request
Not all problems are found #345
Closed
@vbrandl
Copy link
Contributor Author

vbrandl commented Dec 5, 2020

I added a testcase for export FOOBAR and had to change the parameter used to generate the error message. Also get_key will now always return the stripped str.

@mgrachev mgrachev merged commit 1152caf into dotenv-linter:master Dec 5, 2020
@mgrachev
Copy link
Member

mgrachev commented Dec 5, 2020

@vbrandl Thanks a lot! ⚡️

@vbrandl vbrandl deleted the issue_345 branch December 5, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

Not all problems are found

2 participants

@vbrandl @mgrachev