KEMBAR78
fix(#343): Add check for whitespace by sebastiantoh · Pull Request #349 · dotenv-linter/dotenv-linter · GitHub
Skip to content

fix(#343): Add check for whitespace #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2020
Merged

fix(#343): Add check for whitespace #349

merged 2 commits into from
Dec 5, 2020

Conversation

sebastiantoh
Copy link
Contributor

@sebastiantoh sebastiantoh commented Dec 5, 2020 •
edited by mgrachev
Loading

This PR fixes the issue in #343.

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@codecov-io
Copy link

codecov-io commented Dec 5, 2020 •
edited
Loading

Codecov Report

Merging #349 (4764239) into master (1152caf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #349   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files          34       34           
  Lines        2417     2419    +2     
=======================================
+ Hits         2323     2325    +2     
  Misses         94       94
Impacted Files Coverage Δ
src/checks/quote_character.rs 94.64% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1152caf...3ce9e0e. Read the comment docs.

mgrachev
mgrachev approved these changes Dec 5, 2020
View reviewed changes
Copy link
Member

@mgrachev mgrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebastiantoh 👋 Thank you for your contribution! 👍

@mgrachev mgrachev added this to the v3.0.0 milestone Dec 5, 2020
@mgrachev mgrachev linked an issue Dec 5, 2020 that may be closed by this pull request
Many values SHOULD be quoted #343
Closed
@mgrachev mgrachev merged commit 9f84ee5 into dotenv-linter:master Dec 5, 2020
@mgrachev
Copy link
Member

mgrachev commented Dec 5, 2020

@sebastiantoh Can you update the documentation for this check?

🙏 If it’s not difficult for you, please support the project - click on the star on GitHub ⭐️

@sebastiantoh sebastiantoh mentioned this pull request Dec 5, 2020
Closed
@sebastiantoh
Copy link
Contributor Author

@sebastiantoh Can you update the documentation for this check?

Sure, I've submitted a PR to update the documentation as well!

pray If it’s not difficult for you, please support the project - click on the star on GitHub star

Done!

@sebastiantoh sebastiantoh mentioned this pull request Dec 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

Many values SHOULD be quoted

3 participants

@sebastiantoh @codecov-io @mgrachev