KEMBAR78
perf: add benchmark by mgrachev · Pull Request #351 · dotenv-linter/dotenv-linter · GitHub
Skip to content

perf: add benchmark #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2020
Merged

perf: add benchmark #351

merged 2 commits into from
Dec 7, 2020

Conversation

@mgrachev
Copy link
Member

@mgrachev mgrachev commented Dec 6, 2020 •
edited by DDtKey
Loading

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@codecov-io
Copy link

codecov-io commented Dec 6, 2020 •
edited
Loading

Codecov Report

Merging #351 (e8cfb83) into master (9f84ee5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #351   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files          34       34           
  Lines        2419     2419           
=======================================
  Hits         2325     2325           
  Misses         94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f84ee5...e8cfb83. Read the comment docs.

mstruebing
mstruebing approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@mstruebing mstruebing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

DDtKey
DDtKey approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning on adding this to dotenv-linter.github.io?

@mgrachev
Copy link
Member Author

mgrachev commented Dec 7, 2020

Are you planning on adding this to dotenv-linter.github.io?

I haven't thought about it yet. Does it make sense?

@mgrachev mgrachev merged commit 110b236 into master Dec 7, 2020
@mgrachev mgrachev deleted the add-benchmark branch December 7, 2020 17:03
@vbrandl vbrandl mentioned this pull request Dec 8, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mstruebing mstruebing mstruebing approved these changes

@DDtKey DDtKey DDtKey approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mgrachev @codecov-io @mstruebing @DDtKey