KEMBAR78
fix: remove extra Result wrapping to fix clippy by DDtKey Β· Pull Request #374 Β· dotenv-linter/dotenv-linter Β· GitHub
Skip to content

fix: remove extra Result wrapping to fix clippy #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2021
Merged

fix: remove extra Result wrapping to fix clippy #374

merged 2 commits into from
Mar 11, 2021

Conversation

DDtKey
Copy link
Member

@DDtKey DDtKey commented Mar 10, 2021 •
edited
Loading

This is a pretty simple solution, but I would not like to see the CI failing status for a long time πŸ™‚
Closes #373

βœ” Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@DDtKey DDtKey requested a review from mgrachev March 10, 2021 19:07
@codecov-io
Copy link

Codecov Report

Merging #374 (55454fa) into master (5ffb809) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
+ Coverage   95.28%   95.32%   +0.04%     
==========================================
  Files          36       36              
  Lines        2376     2376              
==========================================
+ Hits         2264     2265       +1     
+ Misses        112      111       -1
Impacted Files Coverage Ξ”
src/lib.rs 87.78% <100.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 5ffb809...77e1a47. Read the comment docs.

@mgrachev mgrachev merged commit 947642b into master Mar 11, 2021
@mgrachev mgrachev deleted the fix-clippy branch March 11, 2021 08:15
@mgrachev
Copy link
Member

@DDtKey Thank you πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove Result from the return type

3 participants

@DDtKey @codecov-io @mgrachev