KEMBAR78
perf: add benchmark for check function by mgrachev · Pull Request #376 · dotenv-linter/dotenv-linter · GitHub
Skip to content

perf: add benchmark for check function #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2021
Merged

perf: add benchmark for check function #376

merged 2 commits into from
Mar 13, 2021

Conversation

mgrachev
Copy link
Member

@mgrachev mgrachev commented Mar 12, 2021 •
edited
Loading

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@mgrachev mgrachev force-pushed the add-benchmark branch 4 times, most recently from 72daa1b to 9e8c845 Compare March 12, 2021 14:03
@codecov-io
Copy link

codecov-io commented Mar 12, 2021 •
edited
Loading

Codecov Report

Merging #376 (db08544) into master (54b8342) will not change coverage.
The diff coverage is 96.22%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #376   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files          36       37    +1     
  Lines        2376     2376           
=======================================
  Hits         2265     2265           
  Misses        111      111
Impacted Files Coverage Δ
src/common/file_entry.rs 97.01% <ø> (ø)
src/lib.rs 87.78% <88.23%> (ø)
src/cli.rs 100.00% <100.00%> (ø)
src/fs_utils.rs 92.04% <100.00%> (ø)
src/main.rs 80.00% <100.00%> (-10.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54b8342...db08544. Read the comment docs.

@mgrachev mgrachev force-pushed the add-benchmark branch 12 times, most recently from d407243 to 1961c8a Compare March 12, 2021 16:57
DDtKey
DDtKey reviewed Mar 12, 2021
View reviewed changes
@mgrachev mgrachev force-pushed the add-benchmark branch 9 times, most recently from de1d29b to 58a6099 Compare March 13, 2021 17:42
@mgrachev
perf: add benchmark for check function
09366ef 
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@mgrachev mgrachev requested a review from a team March 13, 2021 17:50
@mgrachev mgrachev requested a review from DDtKey March 13, 2021 17:54
DDtKey
DDtKey reviewed Mar 13, 2021
View reviewed changes
DDtKey
DDtKey reviewed Mar 13, 2021
View reviewed changes
@mgrachev mgrachev merged commit 1d7577a into master Mar 13, 2021
@mgrachev mgrachev deleted the add-benchmark branch March 13, 2021 20:13
@mgrachev mgrachev mentioned this pull request Mar 15, 2021
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DDtKey DDtKey DDtKey approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgrachev @codecov-io @DDtKey