KEMBAR78
perf: add benchmark action by mgrachev · Pull Request #378 · dotenv-linter/dotenv-linter · GitHub
Skip to content

perf: add benchmark action #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2021
Merged

perf: add benchmark action #378

merged 1 commit into from
Mar 14, 2021

Conversation

mgrachev
Copy link
Member

@mgrachev mgrachev commented Mar 13, 2021 •
edited
Loading

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@codecov-io
Copy link

codecov-io commented Mar 13, 2021 •
edited
Loading

Codecov Report

Merging #378 (795717b) into master (1d7577a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   95.32%   95.33%           
=======================================
  Files          37       37           
  Lines        2376     2377    +1     
=======================================
+ Hits         2265     2266    +1     
  Misses        111      111
Impacted Files Coverage Δ
src/lib.rs 87.87% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d7577a...795717b. Read the comment docs.

@mgrachev mgrachev force-pushed the add-benchmark-action branch 2 times, most recently from 89b676e to c28c64b Compare March 13, 2021 19:49
DDtKey
DDtKey reviewed Mar 13, 2021
View reviewed changes
@mgrachev mgrachev force-pushed the add-benchmark-action branch 4 times, most recently from 05a0934 to 9469176 Compare March 13, 2021 20:43
@github-actions
Copy link

Benchmark for 8df04e3

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 67.2±4.67µs 68.5±3.79µs -1.90%

@mgrachev mgrachev force-pushed the add-benchmark-action branch 2 times, most recently from 28c9309 to 244b95e Compare March 14, 2021 09:13
@github-actions
Copy link

Benchmark for f239aa3

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 68.0±3.16µs 69.3±3.01µs -1.88%

@github-actions
Copy link

Benchmark for c449f90

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 71.0±3.26µs 73.7±5.18µs -3.66%

@github-actions
Copy link

Benchmark for c449f90

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 76.9±11.93µs 77.5±8.56µs -0.77%

@mgrachev mgrachev force-pushed the add-benchmark-action branch from 244b95e to df5fed6 Compare March 14, 2021 09:31
@github-actions
Copy link

Benchmark for 26231f5

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 67.4±4.14µs 69.1±3.42µs -2.46%

@github-actions
Copy link

Benchmark for 26231f5

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 66.3±1.14µs 65.7±0.97µs +0.91%

@mgrachev mgrachev force-pushed the add-benchmark-action branch 2 times, most recently from e0e6d02 to b5ed303 Compare March 14, 2021 10:29
@github-actions
Copy link

Benchmark for 7d34699

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 56.5±3.27µs 56.7±3.56µs -0.35%

@mgrachev mgrachev force-pushed the add-benchmark-action branch from b5ed303 to 9b06e4c Compare March 14, 2021 13:31
@github-actions
Copy link

Benchmark for 6bf0270

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 10.2±0.03ms 73.8±2.53µs +13721.14%

@mgrachev mgrachev force-pushed the add-benchmark-action branch from 9b06e4c to b5b2f30 Compare March 14, 2021 14:06
@github-actions
Copy link

Benchmark for 031e87d

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 72.4±4.49µs 70.8±3.79µs +2.26%

@mgrachev mgrachev force-pushed the add-benchmark-action branch from b5b2f30 to 1456348 Compare March 14, 2021 14:11
@github-actions
Copy link

Benchmark for 84ce6b5

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 10.2±0.01ms 70.1±9.93µs +14450.64%

@mgrachev mgrachev force-pushed the add-benchmark-action branch from 1456348 to 795717b Compare March 14, 2021 14:15
@github-actions
Copy link

Benchmark for 7ad0202

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 10.2±0.03ms 64.4±4.82µs +15738.51%

@mgrachev
perf: add action to compare benchmarks
7428d7d 
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@mgrachev mgrachev force-pushed the add-benchmark-action branch from 795717b to 7428d7d Compare March 14, 2021 14:51
@github-actions
Copy link

Benchmark for 5cf477a

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 69.6±3.20µs 73.1±2.57µs -4.79%

@mgrachev mgrachev requested a review from a team March 14, 2021 14:57
DDtKey
DDtKey approved these changes Mar 14, 2021
View reviewed changes
Copy link
Member

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🚀

@mgrachev mgrachev merged commit 492d3a4 into master Mar 14, 2021
@mgrachev mgrachev deleted the add-benchmark-action branch March 14, 2021 17:38
@mgrachev mgrachev mentioned this pull request Mar 15, 2021
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DDtKey DDtKey DDtKey approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgrachev @codecov-io @DDtKey