KEMBAR78
Print message if there are no input files (#384) by jodli · Pull Request #392 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Print message if there are no input files (#384) #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2021
Merged

Print message if there are no input files (#384) #392

merged 2 commits into from
Mar 22, 2021

Conversation

@jodli
Copy link
Contributor

@jodli jodli commented Mar 18, 2021 •
edited
Loading

This implements #384

I had to change the exclude tests as well, as they just excluded all loaded files... :)

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@jodli jodli force-pushed the master branch 2 times, most recently from 88f1da6 to edc09f7 Compare March 18, 2021 21:19
@jodli jodli changed the title feat: Print message if there are no input files (#384) Print message if there are no input files (#384) Mar 18, 2021
mstruebing
mstruebing previously approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@mstruebing mstruebing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work I like it a lot :)

@mgrachev mgrachev linked an issue Mar 21, 2021 that may be closed by this pull request
Print a message "Nothing to check" #384
Closed
mgrachev
mgrachev reviewed Mar 21, 2021
View reviewed changes
Copy link
Member

@mgrachev mgrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jodli 👋 Thank you for your contribution ✌️

I have left a comment. Please take a look at it 👀

@mgrachev mgrachev added this to the v3.1.0 milestone Mar 21, 2021
@codecov-io
Copy link

Codecov Report

Merging #392 (d44e3de) into master (9ffbbe7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #392   +/-   ##
=======================================
  Coverage   95.57%   95.58%           
=======================================
  Files          37       37           
  Lines        2375     2380    +5     
=======================================
+ Hits         2270     2275    +5     
  Misses        105      105
Impacted Files Coverage Δ
src/common/output/check.rs 100.00% <100.00%> (ø)
src/lib.rs 90.00% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ffbbe7...d44e3de. Read the comment docs.

@mgrachev mgrachev merged commit 4b273d8 into dotenv-linter:master Mar 22, 2021
@mgrachev
Copy link
Member

@jodli Thank you for your help ❤️

🙏 If it’s not difficult for you, please support the project - star on GitHub ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

@DDtKey DDtKey DDtKey approved these changes

@mstruebing mstruebing mstruebing left review comments

Assignees

No one assigned

Labels

None yet

Milestone

v3.1.0

Development

Successfully merging this pull request may close these issues.

Print a message "Nothing to check"

5 participants

@jodli @codecov-io @mgrachev @mstruebing @DDtKey