KEMBAR78
Print message if there are no input files for fix subcommand (#385) by mdycz · Pull Request #394 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Print message if there are no input files for fix subcommand (#385) #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 24, 2021
Merged

Print message if there are no input files for fix subcommand (#385) #394

merged 3 commits into from
Mar 24, 2021

Conversation

mdycz
Copy link
Contributor

@mdycz mdycz commented Mar 19, 2021 •
edited by DDtKey
Loading

Closes #385

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);

@mdycz mdycz changed the title Print message if there are no input files for fix subcommand Print message if there are no input files for fix subcommand (#385) Mar 19, 2021
@codecov-io
Copy link

Codecov Report

Merging #394 (2616c9b) into master (492d3a4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 2616c9b differs from pull request most recent head 6cf3ad3. Consider uploading reports for the commit 6cf3ad3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
+ Coverage   95.32%   95.34%   +0.01%     
==========================================
  Files          37       37              
  Lines        2376     2382       +6     
==========================================
+ Hits         2265     2271       +6     
  Misses        111      111
Impacted Files Coverage Δ
src/common/output/fix.rs 100.00% <100.00%> (ø)
src/lib.rs 87.96% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 492d3a4...6cf3ad3. Read the comment docs.

mstruebing
mstruebing previously approved these changes Mar 20, 2021
View reviewed changes
Copy link
Member

@mstruebing mstruebing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, for me it looks good!

mgrachev
mgrachev reviewed Mar 21, 2021
View reviewed changes
Copy link
Member

@mgrachev mgrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdycz 👋 Thank you for your contribution 🚀

I have left some comments. Please take a look at them 👀

@mgrachev mgrachev added this to the v3.1.0 milestone Mar 21, 2021
@mgrachev mgrachev merged commit dd165c3 into dotenv-linter:master Mar 24, 2021
@mgrachev
Copy link
Member

@mdycz Thank you for your help ✌️

🙏 If it’s not difficult for you, please support the project - star on GitHub ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

@DDtKey DDtKey DDtKey approved these changes

@mstruebing mstruebing mstruebing left review comments

Assignees

No one assigned

Labels

None yet

Milestone

v3.1.0

Development

Successfully merging this pull request may close these issues.

Print a message "Nothing to fix"

5 participants

@mdycz @codecov-io @mgrachev @mstruebing @DDtKey