KEMBAR78
perf: add benchmark for compare function by FrancisMurillo · Pull Request #395 · dotenv-linter/dotenv-linter · GitHub
Skip to content

perf: add benchmark for compare function #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 23, 2021
Merged

perf: add benchmark for compare function #395

merged 2 commits into from
Mar 23, 2021

Conversation

@FrancisMurillo
Copy link
Contributor

@FrancisMurillo FrancisMurillo commented Mar 20, 2021 •
edited
Loading

Add benchmark for compare function.

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@codecov-io
Copy link

codecov-io commented Mar 20, 2021 •
edited
Loading

Codecov Report

Merging #395 (613e9f3) into master (9ffbbe7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #395   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files          37       37           
  Lines        2375     2375           
=======================================
  Hits         2270     2270           
  Misses        105      105

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ffbbe7...613e9f3. Read the comment docs.

@FrancisMurillo FrancisMurillo mentioned this pull request Mar 20, 2021
Closed
@FrancisMurillo FrancisMurillo force-pushed the compare-benchmark branch 2 times, most recently from e10de2b to 98e96c4 Compare March 20, 2021 11:27
@a4blue a4blue mentioned this pull request Mar 21, 2021
Closed
@mgrachev mgrachev linked an issue Mar 21, 2021 that may be closed by this pull request
Add a benchmark for the compare function #390
Closed
@mgrachev mgrachev added this to the v3.1.0 milestone Mar 21, 2021
mgrachev
mgrachev reviewed Mar 21, 2021
View reviewed changes
Copy link
Member

@mgrachev mgrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrancisMurillo 👋 Thank you for your contribution 🙂

I have left some comments. Please take a look at them 👀

@mgrachev mgrachev mentioned this pull request Mar 21, 2021
Closed
3 tasks
@mgrachev mgrachev merged commit b541bd6 into dotenv-linter:master Mar 23, 2021
@mgrachev
Copy link
Member

@FrancisMurillo Thank you for your help 👍

🙏 If it’s not difficult for you, please support the project - star on GitHub ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

v3.1.0

Development

Successfully merging this pull request may close these issues.

Add a benchmark for the compare function

3 participants

@FrancisMurillo @codecov-io @mgrachev