KEMBAR78
Replace String on Into<String> for all TestDir methods (#387) by ebobrow · Pull Request #397 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Replace String on Into<String> for all TestDir methods (#387) #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 21, 2021
Merged

Replace String on Into<String> for all TestDir methods (#387) #397

merged 4 commits into from
Mar 21, 2021

Conversation

ebobrow
Copy link
Contributor

@ebobrow ebobrow commented Mar 21, 2021

Closes #387

✔ Checklist:

@codecov-io
Copy link

Codecov Report

Merging #397 (9e69726) into master (492d3a4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #397   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files          37       37           
  Lines        2376     2376           
=======================================
  Hits         2265     2265           
  Misses        111      111

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 492d3a4...9e69726. Read the comment docs.

@mgrachev mgrachev added this to the v3.1.0 milestone Mar 21, 2021
mgrachev
mgrachev reviewed Mar 21, 2021
View reviewed changes
Copy link
Member

@mgrachev mgrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebobrow 👋 Thank you for your contribution 🚀

I have left a comment. Please take a look at it 👀

Also, please fix a warning from commitlint.

@ebobrow @mgrachev
docs: fix changelog.md
8126b7a 
Co-authored-by: Grachev Mikhail <work@mgrachev.com>
@ebobrow
Copy link
Contributor Author

ebobrow commented Mar 21, 2021

Thank you! Sorry, I'm new to open source.

@DDtKey
Copy link
Member

DDtKey commented Mar 21, 2021

@ebobrow thank you for your PR 👍
Can you resolve conflict from the master branch?

@mgrachev mgrachev merged commit 9ffbbe7 into dotenv-linter:master Mar 21, 2021
@mgrachev
Copy link
Member

@ebobrow Thank you for your help ❤️

🙏 If it’s not difficult for you, please support the project - star on GitHub ⭐️

@ebobrow ebobrow deleted the iss387 branch March 21, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

@DDtKey DDtKey DDtKey approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

v3.1.0

Development

Successfully merging this pull request may close these issues.

Replace String on Into<String> for all TestDir methods

4 participants

@ebobrow @codecov-io @DDtKey @mgrachev