KEMBAR78
Print a message "Nothing to compare" (#398) by jakecorrenti · Pull Request #398 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Print a message "Nothing to compare" (#398) #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 30, 2021
Merged

Print a message "Nothing to compare" (#398) #398

merged 5 commits into from
Mar 30, 2021

Conversation

@jakecorrenti
Copy link
Contributor

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@codecov-io
Copy link

Codecov Report

Merging #398 (1d340b4) into master (492d3a4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
+ Coverage   95.32%   95.34%   +0.01%     
==========================================
  Files          37       37              
  Lines        2376     2382       +6     
==========================================
+ Hits         2265     2271       +6     
  Misses        111      111
Impacted Files Coverage Δ
src/common/output/compare.rs 100.00% <100.00%> (ø)
src/lib.rs 87.96% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 492d3a4...1d340b4. Read the comment docs.

@mgrachev mgrachev linked an issue Mar 21, 2021 that may be closed by this pull request
Print a message "Nothing to compare" #386
Closed
mgrachev
mgrachev reviewed Mar 21, 2021
View reviewed changes
Copy link
Member

@mgrachev mgrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakecorrenti 👋 Thank you for your contribution 👍

I have left a comment. Please take a look at it 👀

@mgrachev mgrachev added this to the v3.1.0 milestone Mar 21, 2021
@jakecorrenti jakecorrenti changed the title Print a message "Nothing to compare" (#386) Print a message "Nothing to compare" (#398) Mar 21, 2021
@mgrachev mgrachev merged commit fb36bb0 into dotenv-linter:master Mar 30, 2021
@mgrachev
Copy link
Member

@jakecorrenti Thank you for your help ✌️

🙏 If it’s not difficult for you, please support the project - star on GitHub ⭐️

@jakecorrenti jakecorrenti deleted the jakecorrenti/print-nothing-to-compare branch April 5, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

v3.1.0

Development

Successfully merging this pull request may close these issues.

Print a message "Nothing to compare"

3 participants

@jakecorrenti @codecov-io @mgrachev