KEMBAR78
addressing issue #408 by JuanMarchetto · Pull Request #418 · dotenv-linter/dotenv-linter · GitHub
Skip to content

addressing issue #408 #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 18, 2021
Merged

addressing issue #408 #418

merged 6 commits into from
Apr 18, 2021

Conversation

@JuanMarchetto
Copy link
Contributor

@JuanMarchetto JuanMarchetto commented Apr 12, 2021 •
edited
Loading

Added condition to return None if the value of the variable contains $ character

✔ Checklist:

@mgrachev mgrachev added this to the v3.1.0 milestone Apr 12, 2021
@mgrachev mgrachev linked an issue Apr 12, 2021 that may be closed by this pull request
Fix QuoteCharacterChecker for values with substitution keys #408
Closed
@mgrachev
Copy link
Member

@JuanMarchetto 👋 Thank you for your contribution ✌️

Please do these actions:

And fix CI - all checks have to be green ✅

DDtKey
DDtKey reviewed Apr 12, 2021
View reviewed changes
@mgrachev
Copy link
Member

@JuanMarchetto Hey! Do you have any progress on this?

@JuanMarchetto
Copy link
Contributor Author

@JuanMarchetto Hey! Do you have any progress on this?

Sorry, I'm been very busy this last week, but I will be working on this today.

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@523c20b). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #418   +/-   ##
=========================================
  Coverage          ?   99.01%           
=========================================
  Files             ?       37           
  Lines             ?     2647           
  Branches          ?        0           
=========================================
  Hits              ?     2621           
  Misses            ?       26           
  Partials          ?        0
Impacted Files Coverage Δ
src/checks/quote_character.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523c20b...91c35b9. Read the comment docs.

@JuanMarchetto
Copy link
Contributor Author

hi, @mgrachev i think this PR is ready now, thanks!

DDtKey
DDtKey reviewed Apr 18, 2021
View reviewed changes
JuanMarchetto and others added 2 commits April 18, 2021 13:00
@JuanMarchetto @DDtKey
chore: rename function
e65f432 
Co-authored-by: Artem Medvedev <ddttkey@gmail.com>
@JuanMarchetto @DDtKey
chore: add all cases to test
91c35b9 
Co-authored-by: Artem Medvedev <ddttkey@gmail.com>
DDtKey
DDtKey approved these changes Apr 18, 2021
View reviewed changes
Copy link
Member

@DDtKey DDtKey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! 👍

@mgrachev mgrachev merged commit 0855983 into dotenv-linter:master Apr 18, 2021
@mgrachev
Copy link
Member

@JuanMarchetto Thank you for your help 💪

🙏 If it’s not difficult for you, please support the project - star on GitHub ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

@DDtKey DDtKey DDtKey approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

v3.1.0

Development

Successfully merging this pull request may close these issues.

Fix QuoteCharacterChecker for values with substitution keys

4 participants

@JuanMarchetto @mgrachev @codecov-commenter @DDtKey