KEMBAR78
Add missing integration tests by gosolivs · Pull Request #420 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Add missing integration tests #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Apr 20, 2021
Merged

Add missing integration tests #420

merged 17 commits into from
Apr 20, 2021

Conversation

@gosolivs
Copy link
Contributor

@gosolivs gosolivs commented Apr 17, 2021 •
edited
Loading

Hi! I mentioned that there aren't enough real checks of rules for src/checks. Would it be a good idea if I add them?

✔ Checklist:

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2021 •
edited
Loading

Codecov Report

Merging #420 (35a956e) into master (0855983) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #420   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files          37       37           
  Lines        2647     2647           
=======================================
  Hits         2621     2621           
  Misses         26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0855983...35a956e. Read the comment docs.

@gosolivs gosolivs marked this pull request as ready for review April 17, 2021 18:26
@gosolivs gosolivs changed the title Add missing real checks Add missing integration tests Apr 19, 2021
@mgrachev mgrachev added this to the v3.1.0 milestone Apr 19, 2021
mgrachev
mgrachev reviewed Apr 19, 2021
View reviewed changes
Copy link
Member

@mgrachev mgrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gosolivs 👋 Thank you for your contribution 👍

Please add integration tests for the new substitution key check.

@mgrachev mgrachev requested a review from a team April 19, 2021 15:02
@mgrachev mgrachev requested a review from DDtKey April 19, 2021 20:38
DDtKey
DDtKey approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR 👍

@DDtKey DDtKey merged commit 889636e into dotenv-linter:master Apr 20, 2021
@gosolivs gosolivs deleted the add_checks_tests branch April 20, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

@DDtKey DDtKey DDtKey approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

v3.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@gosolivs @codecov-commenter @mgrachev @DDtKey