KEMBAR78
feat: add substitution key fixer by DDtKey · Pull Request #428 · dotenv-linter/dotenv-linter · GitHub
Skip to content

feat: add substitution key fixer #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 8, 2021
Merged

feat: add substitution key fixer #428

merged 2 commits into from
Jun 8, 2021

Conversation

@DDtKey
Copy link
Member

@DDtKey DDtKey commented Jun 8, 2021 •
edited
Loading

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@DDtKey DDtKey added this to the v3.1.0 milestone Jun 8, 2021
@DDtKey DDtKey requested a review from a team June 8, 2021 15:38
@github-actions
Copy link

github-actions bot commented Jun 8, 2021

Benchmark for 9fb88e1

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 54.9±2.25µs 60.4±5.19µs -9.11%
dotenv_linter compare 47.7±4.21µs 49.4±3.84µs -3.44%
dotenv_linter fix 199.7±153.40µs 182.1±13.17µs +9.67%
dotenv_linter fix with backup 239.4±73.68µs 235.8±51.11µs +1.53%

@github-actions
Copy link

github-actions bot commented Jun 8, 2021

Benchmark for 3069e6b

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 59.2±0.16µs 59.4±0.95µs -0.34%
dotenv_linter compare 47.8±0.24µs 47.9±0.62µs -0.21%
dotenv_linter fix 129.7±1.93µs 129.9±20.93µs -0.15%
dotenv_linter fix with backup 160.0±2.59µs 165.4±3.17µs -3.26%

@mgrachev mgrachev merged commit c5fd50c into master Jun 8, 2021
@mgrachev mgrachev deleted the substitution-fixer branch June 8, 2021 16:44
@mgrachev
Copy link
Member

mgrachev commented Jun 8, 2021

@DDtKey Thanks a lot ❤️

@mgrachev mgrachev mentioned this pull request Jun 8, 2021
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

v3.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@DDtKey @mgrachev