KEMBAR78
using flatten instead of filter with inwrap by Fcukit · Pull Request #434 · dotenv-linter/dotenv-linter · GitHub
Skip to content

using flatten instead of filter with inwrap #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2021
Merged

using flatten instead of filter with inwrap #434

merged 1 commit into from
Jun 22, 2021

Conversation

@Fcukit
Copy link
Contributor

@Fcukit Fcukit commented Jun 22, 2021 •
edited by mgrachev
Loading

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@mgrachev mgrachev linked an issue Jun 22, 2021 that may be closed by this pull request
Fix warning: filter for Some followed by unwrap #433
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2021 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.94%. Comparing base (5d2bf2e) to head (fbdfdb3).
Report is 194 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
- Coverage   98.94%   98.94%   -0.01%     
==========================================
  Files          39       39              
  Lines        2665     2664       -1     
==========================================
- Hits         2637     2636       -1     
  Misses         28       28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mstruebing
mstruebing reviewed Jun 22, 2021
View reviewed changes
Copy link
Member

@mstruebing mstruebing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Fcukit thank you very much for that PR.

Your commit message is not following commit lint standards, that's why the pipeline is failing.
You can read more about it here: https://commitlint.js.org/#/concepts-commit-conventions

Your commit message could be:

refactor: using flatten instead of filter with unwrap

closes #433

@Fcukit Fcukit force-pushed the issue-433-warning-filter branch 2 times, most recently from 9afbd34 to 899c5d0 Compare June 22, 2021 08:06
@Fcukit Fcukit force-pushed the issue-433-warning-filter branch from 899c5d0 to fbdfdb3 Compare June 22, 2021 09:02
@mgrachev
Copy link
Member

@Fcukit Thank you for your contribution 🚀

@mgrachev mgrachev merged commit 7237b17 into dotenv-linter:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mstruebing mstruebing mstruebing left review comments

@mgrachev mgrachev mgrachev approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix warning: filter for Some followed by unwrap

4 participants

@Fcukit @codecov-commenter @mgrachev @mstruebing