KEMBAR78
build: add aarch64 support by DDtKey · Pull Request #436 · dotenv-linter/dotenv-linter · GitHub
Skip to content

build: add aarch64 support #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2021
Merged

build: add aarch64 support #436

merged 1 commit into from
Aug 23, 2021

Conversation

@DDtKey
Copy link
Member

@DDtKey DDtKey commented Aug 13, 2021 •
edited
Loading

aarch64 support for mac, linux, windows
These might be useful changes because aarch64 is gaining popularity.
Closes #435

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@DDtKey DDtKey requested a review from mgrachev August 13, 2021 09:32
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2021 •
edited
Loading

Codecov Report

Merging #436 (b1eb9da) into master (c95ad3e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files          40       40           
  Lines        2768     2768           
=======================================
  Hits         2739     2739           
  Misses         29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c95ad3e...b1eb9da. Read the comment docs.

@DDtKey
Copy link
Member Author

DDtKey commented Aug 13, 2021

Hi @dotenv-linter/core,
Regarding the clippy, I think we need to fix it with a separate issue (I don't change rust-code in the PR)

@github-actions
Copy link

Benchmark for 9fe21e4

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 74.7±5.39µs 76.7±3.25µs -2.61%
dotenv_linter compare 61.2±2.27µs 59.2±3.01µs +3.38%
dotenv_linter fix 212.8±151.54µs 209.5±68.74µs +1.58%
dotenv_linter fix with backup 263.9±110.87µs 283.4±155.59µs -6.88%

@dotenv-linter dotenv-linter deleted a comment from github-actions bot Aug 13, 2021
@github-actions
Copy link

Benchmark for d88b684

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 71.7±3.73µs 72.5±4.97µs -1.10%
dotenv_linter compare 57.6±2.63µs 56.6±3.86µs +1.77%
dotenv_linter fix 197.7±77.44µs 195.9±58.11µs +0.92%
dotenv_linter fix with backup 269.0±138.88µs 262.8±142.95µs +2.36%

@DDtKey DDtKey requested a review from mstruebing August 13, 2021 10:39
mstruebing
mstruebing previously approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@mstruebing mstruebing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Clippy needs to have something changed that this is happening - do we have the possibility to use a specific clippy version? Does this might fix the issue?

@DDtKey
Copy link
Member Author

DDtKey commented Aug 13, 2021

Clippy needs to have something changed that this is happening - do we have the possibility to use a specific clippy version? Does this might fix the issue?

I think this should help us, because each clippy update may lead to warnings like this 🤔

@github-actions
Copy link

Benchmark for f680081

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 55.5±2.99µs 55.8±3.76µs -0.54%
dotenv_linter compare 43.7±1.53µs 47.8±4.30µs -8.58%
dotenv_linter fix 218.3±167.77µs 203.9±101.02µs +7.06%
dotenv_linter fix with backup 255.2±108.94µs 258.9±114.69µs -1.43%

@mgrachev mgrachev merged commit 1bd8c82 into master Aug 23, 2021
@mgrachev mgrachev deleted the aarch64 branch August 23, 2021 15:44
@mgrachev
Copy link
Member

@DDtKey Thanks! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

@mstruebing mstruebing mstruebing left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Apple Silicon (m1)

4 participants

@DDtKey @codecov-commenter @mgrachev @mstruebing