KEMBAR78
chore: fix clippy warnings by mgrachev · Pull Request #437 · dotenv-linter/dotenv-linter · GitHub
Skip to content

chore: fix clippy warnings #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2021
Merged

chore: fix clippy warnings #437

merged 1 commit into from
Aug 23, 2021

Conversation

@mgrachev
Copy link
Member

@mgrachev mgrachev commented Aug 23, 2021 •
edited
Loading

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@mgrachev
chore: fix clippy warnings
0e12c7c 
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@github-actions
Copy link

Benchmark for 5c37fbb

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 59.7±0.42µs 60.7±0.26µs -1.65%
dotenv_linter compare 48.2±0.25µs 48.5±0.21µs -0.62%
dotenv_linter fix 155.9±138.51µs 157.8±107.50µs -1.20%
dotenv_linter fix with backup 187.1±74.16µs 216.5±220.20µs -13.58%

@codecov-commenter
Copy link

Codecov Report

Merging #437 (0e12c7c) into master (313f329) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #437   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files          40       40           
  Lines        2765     2768    +3     
=======================================
+ Hits         2736     2739    +3     
  Misses         29       29
Impacted Files Coverage Δ
src/checks/duplicated_key.rs 100.00% <100.00%> (ø)
src/checks/ending_blank_line.rs 100.00% <100.00%> (ø)
src/checks/incorrect_delimiter.rs 100.00% <100.00%> (ø)
src/checks/key_without_value.rs 100.00% <100.00%> (ø)
src/checks/leading_character.rs 100.00% <100.00%> (ø)
src/checks/lowercase_key.rs 100.00% <100.00%> (ø)
src/checks/substitution_key.rs 98.76% <100.00%> (ø)
src/checks/unordered_key.rs 100.00% <100.00%> (ø)
src/common/line_entry.rs 100.00% <100.00%> (ø)
src/fixes/incorrect_delimiter.rs 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 313f329...0e12c7c. Read the comment docs.

@mgrachev mgrachev requested a review from a team August 23, 2021 14:39
@mgrachev
Copy link
Member Author

cargo-deny complains about dev-dependencies. I think it's okay 👌

DDtKey
DDtKey approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mgrachev mgrachev merged commit c95ad3e into master Aug 23, 2021
@mgrachev mgrachev deleted the fix-clippy-warnings branch August 23, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DDtKey DDtKey DDtKey approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgrachev @codecov-commenter @DDtKey